icevision icon indicating copy to clipboard operation
icevision copied to clipboard

fixes draw methods for grayscale images

Open lgvaz opened this issue 4 years ago • 5 comments

closes #806

lgvaz avatar Apr 19 '21 21:04 lgvaz

Codecov Report

Merging #807 (26121c3) into master (0d7f18d) will increase coverage by 0.07%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
+ Coverage   87.26%   87.34%   +0.07%     
==========================================
  Files         225      225              
  Lines        4697     4725      +28     
==========================================
+ Hits         4099     4127      +28     
  Misses        598      598              
Flag Coverage Δ
unittests 87.34% <100.00%> (+0.07%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
icevision/visualize/draw_data.py 89.47% <100.00%> (ø)
icevision/core/tasks.py 100.00% <0.00%> (ø)
icevision/models/mmdet/fastai/callbacks.py 100.00% <0.00%> (ø)
icevision/models/torchvision/fastai/callbacks.py 100.00% <0.00%> (ø)
...sion/models/torchvision/lightning/model_adapter.py 100.00% <0.00%> (ø)
icevision/core/record_components.py 79.47% <0.00%> (+0.06%) :arrow_up:
icevision/core/mask.py 88.37% <0.00%> (+0.09%) :arrow_up:
icevision/models/mmdet/lightning/model_adapter.py 96.96% <0.00%> (+0.09%) :arrow_up:
...sion/tfms/albumentations/albumentations_adapter.py 95.58% <0.00%> (+0.11%) :arrow_up:
icevision/core/keypoints.py 93.33% <0.00%> (+0.22%) :arrow_up:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0d7f18d...26121c3. Read the comment docs.

codecov[bot] avatar Apr 19 '21 21:04 codecov[bot]

I think this can be easily merged.

FraPochetti avatar Dec 31 '21 08:12 FraPochetti

@FraPochetti is this still a thing?

lgvaz avatar Mar 09 '22 14:03 lgvaz

@FraPochetti is this still a thing?

We never got back to it. Not sure it is relevant actually.

FraPochetti avatar Mar 09 '22 14:03 FraPochetti

this seems related: https://github.com/airctic/icevision/issues/1080

rbavery avatar Jun 24 '22 22:06 rbavery