Added support for 3 bands float32 tiff images

[AlexandreBrown]

Fixes #1135

[ai-fast-track]

Thanks a lot for your contribution, Alex!

[potipot]

Any idea why the tests are not passing? Maybe we could collaboratively sort this out, I noticed it's been quite a while since they passed even on master.

[AlexandreBrown]

@potipot I haven't figure out why the tests on master are not passing (which is reflected in this MR since the tests fail).
I noticied that most if not all the failing tests seem to be related to name 'create_coco_eval' is not defined but would need to investigate more (this method was not changed or altered in this MR, we get this from master).
At least I was able to confirm that the classes affected by this MR and their test files that I modified and added all pass.

@ai-fast-track We are currently in a weird spot because our team environment currently has to depend on my personal fork branch (not ideal!) therefore we would like to get it merged asap.
Do you think we can create a separate issue for tests and then have it looked independently of this MR since the issue was already present?

I created a new issue so that we can collaborate on fixing the unit tests on master https://github.com/airctic/icevision/issues/1162

[codecov[bot]]

Codecov Report

Merging #1138 (818b7a7) into master (72d30c9) will decrease coverage by 0.47%. The diff coverage is 66.66%.

:exclamation: Current head 818b7a7 differs from pull request most recent head 893ccd0. Consider uploading reports for the commit 893ccd0 to get more accurate results

@@            Coverage Diff             @@
##           master    #1138      +/-   ##
==========================================
- Coverage   85.81%   85.33%   -0.48%     
==========================================
  Files         305      288      -17     
  Lines        6710     6533     -177     
==========================================
- Hits         5758     5575     -183     
- Misses        952      958       +6     

Flag	Coverage Δ
unittests	85.33% <66.66%> (-0.48%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
icevision/data/convert_records_to_coco_style.py	77.16% <18.18%> (-20.71%)	:arrow_down:
icevision/models/inference.py	77.27% <71.42%> (+1.88%)	:arrow_up:
icevision/utils/imageio.py	81.00% <97.05%> (+1.27%)	:arrow_up:
icevision/core/mask.py	81.01% <100.00%> (ø)
icevision/core/record_components.py	81.41% <100.00%> (-0.17%)	:arrow_down:
icevision/data/convert_records_to_fo.py	85.89% <100.00%> (ø)
icevision/models/inference_sahi.py	94.89% <100.00%> (+0.05%)	:arrow_up:
...sion/tfms/albumentations/albumentations_adapter.py	93.33% <100.00%> (ø)
...sion/tfms/albumentations/albumentations_helpers.py	97.87% <100.00%> (ø)
... and 17 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[fstroth]

@ai-fast-track @potipot We fixed a circular import that is currently in the lib. We should merge this asap, everything looks good to me. Can one of you have a second look to be sure, I would merge then.

[potipot]

@AlexandreBrown do you remember what was the go-to approach in icevision? Does the author merge his PR or is it the reviewers responsibility?

[AlexandreBrown]

@AlexandreBrown do you remember what was the go-to approach in icevision? Does the author merge his PR or is it the reviewers responsibility?

In my experience the reviewers merged the PR (basing my response from my previous PR on IceVision).