airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Published 20 hours ago • verified publisher icon airbytehq

Bulk load CDK: crash on no terminal status

Open edgao opened this issue 1 year ago • 3 comments

(copying from slack)

we should crash if we reach end-of-input, but some streams don't have a terminal status. This might happen if e.g. platform crashes before sending us the terminal status message.

(johnny basically wrote this code, I just wanted to have an excuse to get my hands dirty with this part of the codebase)

edgao avatar Oct 14 '24 22:10 edgao

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 4:13pm

vercel[bot] avatar Oct 14 '24 22:10 vercel[bot]

Brilliant! A masterpiece!

johnny-schmidt avatar Oct 14 '24 22:10 johnny-schmidt

actually, you know what would be a good idea? writing a test (I literally was planning to do that, then got distracted 🤦 )

lemme do that, will rerequest review afterward

edgao avatar Oct 14 '24 23:10 edgao

  • #46749 Graphite
  • #46922 Graphite
  • #46921 Graphite
  • #46920 Graphite
  • #46902 Graphite 👈
  • #46925 Graphite
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @edgao and the rest of your teammates on Graphite Graphite

edgao avatar Oct 15 '24 16:10 edgao