airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Published 20 hours ago • verified publisher icon airbytehq

destination-s3: assume role auth

Open stephane-airbyte opened this issue 9 months ago • 4 comments

adding assume-role auth. We created a bunch of secrets in GSM, and allowed to pass an environment into the S3Destination constructor, so we don't modify the system env for everyone.

stephane-airbyte avatar May 15 '24 00:05 stephane-airbyte

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 5:35pm

vercel[bot] avatar May 15 '24 00:05 vercel[bot]

  • #38306 Graphite
  • #38305 Graphite
  • #38204 Graphite 👈
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

stephane-airbyte avatar May 15 '24 00:05 stephane-airbyte

@alafanechere I think the new secrets logic is broken for unit tests, unless I'm missing something obvious

stephane-airbyte avatar May 17 '24 04:05 stephane-airbyte

@alafanechere I think the new secrets logic is broken for unit tests, unless I'm missing something obvious

@stephane-airbyte the new secret logic is not yet in production. I only have seeded metadata files so far, and I'm actively working on changing the secret fetching logic in airbyte-ci. The new secret you added might miss a connector and/or filename label in GSM so that ci_credentials can resolve it.

alafanechere avatar May 17 '24 07:05 alafanechere

Merge activity

  • May 17, 1:52 PM EDT: @stephane-airbyte merged this pull request with Graphite.

stephane-airbyte avatar May 17 '24 17:05 stephane-airbyte

Linking the Loom Demo https://www.loom.com/share/225fe3aa4bab4f379f3f4af99cb425e3

evantahler avatar May 17 '24 23:05 evantahler