airbyte
airbyte copied to clipboard
[skip ci] Add connectorTestSuitesOptions to metadata
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?
- [ ] YES 💚
- [ ] NO ❌
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
airbyte-docs | ⬜️ Ignored (Inspect) | Visit Preview | May 15, 2024 1:01pm |
Looks good to me, i'd like to highlight the fact, that some of the CREDS in GSM are either outdated or not used anymore, it's hard to say confidently which ones are fine to remove, it requires manual check for each source and know what secrets exactly is pulled/pulled and override the previously pulled one, etc
Let's merge, so this is not blocked on us, but when any source or destination is under future maintenance - the engineer should be able to validate the secrets pulled and clean the broken ones / duplicated once from the
metadata.yaml
💯 agree @bazarnov The single thing I know for sure is that any config listed here are passing the check
command, but it does not mean it's actually use.
/approve-and-merge reason="bypassing CI as it's a metedata field introduction touching all connectors"
Myomoto says it looks good