airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

[destination-astra] Explicit projection when reading from Astra DB

Open hemidactylus opened this issue 1 year ago • 2 comments

What

In view of upcoming changes in the Astra DB Data API, this PR explicitly sets a projection every time a find command is executed, in order to ensure all necessary fields of the document are returned by the API.

How

The find_query["projection"] field is always set during the find_documents method body.

Review guide

astra_client.py : added and else clause to ensure the projection is always set.

User Impact

When a future version of the Data API will start excluding the $vector field by default, with this PR the users will not be impacted by any missing field.

Can this PR be safely reverted and rolled back?

  • [x] YES 💚
  • [ ] NO ❌

hemidactylus avatar May 14 '24 09:05 hemidactylus

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2024 0:33am

vercel[bot] avatar May 14 '24 09:05 vercel[bot]

@marcosmarxm Done. Thank you!

hemidactylus avatar May 16 '24 08:05 hemidactylus

@marcosmarxm Hello, anything I can do to help this PR get merged?

hemidactylus avatar Jun 04 '24 09:06 hemidactylus

@hemidactylus my fault here, running CI and will try to get this merged today.

marcosmarxm avatar Jun 05 '24 12:06 marcosmarxm

Hello 👋 , your feedback matters a lot to us. Can you spare just 3 minutes to complete a survey? We're dedicated to making the contributor experience even better, and your input is key to achieving excellence. Thank you for helping us improve!

marcosmarxm avatar Jun 05 '24 17:06 marcosmarxm