airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

✨Source Mailgun: Make Connector Compatible with Builder

Open pabloescoder opened this issue 9 months ago • 3 comments

What

Makes the connector compatible with the Builder UI

How

  • Bump minor version
  • Use Inline Spec
  • Remove $parameters
  • Make it compatible with the Builder

User Impact

Non impacting, done for maintainability

Can this PR be safely reverted and rolled back?

  • [x] YES 💚

pabloescoder avatar May 14 '24 06:05 pabloescoder

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 7:12pm

vercel[bot] avatar May 14 '24 06:05 vercel[bot]

The Basic HTTP Authenticator in the Builder needs the username and password field values to be of the form {{ config[key] }} so I added a new config key called username_do_not_edit with the default value api for the username. (It didn't allow me to hardcode the value api)

pabloescoder avatar May 14 '24 07:05 pabloescoder

@girarda I've defaulted the username to api and removed the extra config value. CI is green.

pabloescoder avatar May 22 '24 22:05 pabloescoder