airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Destinations CDK: CatalogParser sets default namespace

Open edgao opened this issue 9 months ago • 2 comments

  • CatalogParser is now responsible for setting the default namespace on stream objects.
    • This entails a bunch of knock-on changes:
      • All the core async stuff now operates on the original (null) namespace
      • BufferEnqueue also needs to set the default namespace right before handing the message to the queue
      • AsyncStreamConsumer needs to set the default namespace when calling OnCloseFunction
    • I also took the opportunity to make defaultNamespace non-nullable.
  • This allows destinations code to stop thinking about it (i.e. we can remove all our catalog.streams.each(stream.setNamespace) blocks)

closes https://github.com/airbytehq/airbyte-internal-issues/issues/2413

edgao avatar May 10 '24 17:05 edgao

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 4:13pm

vercel[bot] avatar May 10 '24 17:05 vercel[bot]

  • #38121 Graphite: 2 dependent PRs (#38075 Graphite, #39107 Graphite) 👈
  • #38770 Graphite
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @edgao and the rest of your teammates on Graphite Graphite

edgao avatar May 10 '24 17:05 edgao

/publish-java-cdk

:clock2: https://github.com/airbytehq/airbyte/actions/runs/9452125686 :white_check_mark: Successfully published Java CDK version=0.37.0!

edgao avatar Jun 10 '24 16:06 edgao