airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Published 20 hours ago • verified publisher icon airbytehq

Destinations CDK: Set default namespace lower in the async framework call stack

Open edgao opened this issue 9 months ago • 3 comments

closes https://github.com/airbytehq/airbyte-internal-issues/issues/2413 ?

edgao avatar May 09 '24 16:05 edgao

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 10, 2024 5:18pm

vercel[bot] avatar May 09 '24 16:05 vercel[bot]

  • #38086 Graphite 👈
  • #38067 Graphite: 1 other dependent PR (#38622 Graphite)
  • #38331 Graphite
  • #38075 Graphite
  • #38121 Graphite: 1 other dependent PR (#39107 Graphite)
  • #38770 Graphite
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @edgao and the rest of your teammates on Graphite Graphite

edgao avatar May 09 '24 16:05 edgao

@gisripa I got sketched out by some of our catalog/stream handling when I was moving the default namespace stuff into CatalogParser. This PR pushes that logic from AsyncStreamConsumer into BufferEnqueue, which I think means:

  • all async framework code operates on the "real" record/state/stream_status messages (with null namespace)
  • and all destinations code still operates on the nonnull namespace

(I need to restack https://github.com/airbytehq/airbyte/pull/38075 onto this pr now)

edgao avatar May 09 '24 16:05 edgao