airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Feature request: Ability for connectors to know their names and/or send info from metadata.yml into the container

Open aaronsteers opened this issue 1 year ago • 0 comments
trafficstars

The goal here would be for the same connector code to be used in multiple connector variants.

E.g.

  • Postgres could have an RDS/Aurora variant with correct branding, and only the config options relevant to that implementation type.
  • DuckDB could have a MotherDuck variant that just brands as "MotherDuck" - and only provides the config options relevant for MotherDuck connections.

Thanks to @evantahler for pointing me in the direction of this code.

https://github.com/airbytehq/airbyte-platform-internal/blob/7779ac946b9cfcd8be2e31208dfe0112f750dd0d/oss/airbyte-commons-worker/src/main/java/io/airbyte/workers/sync/LauncherWorker.java#L134-L143

This came up recently in slack (internal-only links):

  • https://airbytehq-team.slack.com/archives/C02UF50V9HA/p1715118875377949?thread_ts=1715109625.474229&cid=C02UF50V9HA
  • https://airbytehq-team.slack.com/archives/C05KJKWHNAJ/p1714587898875259?thread_ts=1714587820.346189&cid=C05KJKWHNAJ

Other considerations:

  • If we pair a single connector to multiple registrations, we may also want to expand our CI version bump requirements to require or encourage variants to get their version bumps as well as the base/core version.

aaronsteers avatar May 07 '24 22:05 aaronsteers