airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Audit required-reviewer-checks and CODEOWNERS

Open erohmensing opened this issue 9 months ago • 0 comments

Problem

I feel like the extensibility team gets auto-tagged in too many PRs for review for it to be useful. I'd like to audit it to narrow it down to scopes we'd actually like to review/at least be informed about, to reduce the notification fatigue.

As exhibit A, see my PR filters, the first of which is for "the extensibility team's review is requested, but someone on my team made the pr", and the second is for "the extensibility team's review is requested". Emphasis on the 98 PRs in the latter category (to be fair, its a little egregious at the moment because of BL's PRs, but still)

image.png

Current State

The state of required-reviewer-checks:

image.png
  • Do we still want to review

    • backwards compatibility changes?
    • Test strictness level chnages?
    • Strategic python connector changes?
  • strategic python connector changes is being triggered for non-python changes, e.g. here

CODEOWNERS airbyte: image.png

  • do we want to be tagged in all things CI?

CODEOWNERS airbyte-platform: image.png

image.png

erohmensing avatar Apr 29 '24 16:04 erohmensing