airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

get rid of source-e2e-test-cloud

Open stephane-airbyte opened this issue 10 months ago • 4 comments

What

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • [ ] YES 💚
  • [ ] NO ❌

stephane-airbyte avatar Apr 25 '24 20:04 stephane-airbyte

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2024 8:59pm

vercel[bot] avatar Apr 25 '24 20:04 vercel[bot]

  • #37587 Graphite 👈
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

stephane-airbyte avatar Apr 25 '24 20:04 stephane-airbyte

@evantahler talked about it a bit with Benoit. What I was thinking was :

  1. create a cloud workspace (WS1) with the e2e source
  2. Merge the changes to the OSS connector (don't delete cloud yet)
  3. create a new cloud workspace (WS2) with the e2e source
  4. make sure the e2e source in WS2 is the new "OSS" one
  5. update the prod DB for WS1 to override the connector ID
  6. check that now WS2 has the OSS version
  7. update prod DB to modify the connector ID for all 2e2 source (we can do that gradually obv)
  8. delete the source-e2e-cloud directory

stephane-airbyte avatar Apr 26 '24 18:04 stephane-airbyte

That sounds like a plan! As a note, it looks like there are workspaces that aren't us using this connector for some reason 🤷

evantahler avatar Apr 26 '24 21:04 evantahler