airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

🐛 Source Shopify: Add retry job for status ConnectionErrors [issue 7084]

Open strosek opened this issue 1 year ago • 1 comments

What

Shopify connector is affected by Connection Reset/Aborted errors which wrongly show in traces as system errors and don't have a proper error message. See issue

How

We solved this by making such type of errors retry-able, so these errors don't affect sync jobs immediately.

Review guide

Let's make sure the solution is complete and tests are meaningful. job.py - Added ConnectionError to the list of handled exceptions for retry. base_streams.py - Added condition for 104 status code with retry True. Relevant test cases in test_job.py and unit_test.py, respectively.

User Impact

The user should not see errors related to ConnectionReset/ConnectionAborted as these errors are retried, unless connection is seriously bad.

Can this PR be safely reverted and rolled back?

YES 💚

strosek avatar Apr 24 '24 17:04 strosek

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2024 6:25pm

vercel[bot] avatar Apr 24 '24 17:04 vercel[bot]

Closing as fixed.

bazarnov avatar Jun 26 '24 17:06 bazarnov