airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Destination Redshift: more info in tooltip

Open 13072020 opened this issue 10 months ago • 5 comments

What

Changing the text in a tooltip from: The schema to write raw tables into to The schema to write raw tables into (default: airbyte_internal).

airbyte_internal

Stylistically, this is consistent with the description for JDBC URL Params, also in the same file, which ends with (example: ...).

How

I assume this will work. I just ctrl + f'd for the existing text, and it is only in this spec.json.

A downside is that this is now hardcoded.

User Impact

As a user, I had to experiment to confirm that this option referred to airbyte_internal. Seems more obvious now, but was not during my first explorations.

Can this PR be safely reverted and rolled back?

  • [x] YES 💚
  • [ ] NO ❌

13072020 avatar Apr 19 '24 06:04 13072020

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 11:23am

vercel[bot] avatar Apr 19 '24 06:04 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 19 '24 06:04 CLAassistant

Thanks @13072020

marcosmarxm avatar Apr 22 '24 22:04 marcosmarxm

@marcosmarxm - this is fine to merge as-is, but without the connector version bump the change won't get to users.

evantahler avatar Apr 22 '24 22:04 evantahler

@13072020 we're going to merge your contribution but it won't be release yet. You're going to be able to see the change in the next code change which will update the connector version. Thanks for this fix! 👏

marcosmarxm avatar Apr 22 '24 22:04 marcosmarxm

/approve-and-merge reason="community PR to update description"

evantahler avatar Apr 29 '24 15:04 evantahler

You did it!
finish line

octavia-approvington avatar Apr 29 '24 15:04 octavia-approvington