airbyte
airbyte copied to clipboard
Destination mysql: Switch to dv2 raw tables
Switch the raw tables to DV2 format. See https://github.com/airbytehq/airbyte/pull/36936 for implementing T+D. This PR sets a few "disable T+D" booleans for the sake of being able to run tests; that PR unsets them.
I'll merge https://github.com/airbytehq/airbyte/pull/36936 into this branch and release them as a single major version bump - not planning to publish a version of destination-mysql with just dv2 raw tables.
There's some weird stuff going on in MysqlNameTransformer, which I didn't try to solve here. I mostly just don't understand what all the methods are supposed to do (e.g. how does getIdentifier relate to convertStreamName?). MysqlNameTransformer behaves differently from PostgresNameTransformer, and I elected to work around that inconsistency. IMO we should probably revamp that class to be less opinionated about what tables we create.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
airbyte-docs | ⬜️ Ignored (Inspect) | Visit Preview | Apr 29, 2024 3:11pm |
-
#37322
👈
-
#36935
: 5 other dependent PRs (#34611
, #34612
, #34613
and 2 others)
-
#36929
-
#36926
-
master
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @edgao and the rest of your teammates on Graphite
switching back to draft - CI is failing b/c we can't connect to the testcontainer, will look into it later
closing this PR in favor of https://github.com/airbytehq/airbyte/pull/36936