airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Destination mysql: Switch to dv2 raw tables

Open edgao opened this issue 10 months ago • 3 comments

Switch the raw tables to DV2 format. See https://github.com/airbytehq/airbyte/pull/36936 for implementing T+D. This PR sets a few "disable T+D" booleans for the sake of being able to run tests; that PR unsets them.

I'll merge https://github.com/airbytehq/airbyte/pull/36936 into this branch and release them as a single major version bump - not planning to publish a version of destination-mysql with just dv2 raw tables.

There's some weird stuff going on in MysqlNameTransformer, which I didn't try to solve here. I mostly just don't understand what all the methods are supposed to do (e.g. how does getIdentifier relate to convertStreamName?). MysqlNameTransformer behaves differently from PostgresNameTransformer, and I elected to work around that inconsistency. IMO we should probably revamp that class to be less opinionated about what tables we create.

edgao avatar Apr 15 '24 15:04 edgao

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 3:11pm

vercel[bot] avatar Apr 15 '24 15:04 vercel[bot]

  • #37322 Graphite 👈
  • #36935 Graphite: 5 other dependent PRs (#34611 Graphite, #34612 Graphite, #34613 Graphite and 2 others)
  • #36929 Graphite
  • #36926 Graphite
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @edgao and the rest of your teammates on Graphite Graphite

edgao avatar Apr 15 '24 15:04 edgao

switching back to draft - CI is failing b/c we can't connect to the testcontainer, will look into it later

edgao avatar Apr 17 '24 15:04 edgao

closing this PR in favor of https://github.com/airbytehq/airbyte/pull/36936

edgao avatar Apr 29 '24 16:04 edgao