airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

source-datadog: ensure inline schemas, updated cdk, poetry (where possible)

Open bleonard opened this issue 1 year ago • 5 comments

This was created from a set of automated scripts. In each case, not every update was needed for every connector, but overall here is what happened:

  • auto-schema update -s all description: added descriptions to json and inline schemas
  • connector-code migrate_to_yaml -c all --type source: migrates json schemas to connectors with a manifest
  • airbyte-ci connectors --name=<all modified connectors from above> migrate_to_base_image: makes sure that each is using a base docker image and updates docs
  • airbyte-ci connectors --name=<all modified connectors from above> migrate-to-poetry: moves connectors not already using poetry to do so and updates documentation
  • airbyte-ci connectors --name=<all modified connectors from above> up_to_date: updated the CDK to newer (0.80.0) version

The version number and changelogs were also bumped using the connector-code pulls command.

bleonard avatar Apr 13 '24 00:04 bleonard

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 20, 2024 8:07pm

vercel[bot] avatar Apr 13 '24 00:04 vercel[bot]

I can't figure out what's going on with this. There's a schema validation, but it's validating the $parameters The YAML looks right. @girarda @lmossman ?

cls = <class 'jsonschema.validators.Draft7Validator'>
schema = {'$parameters': {'name': 'monitors', 'path': 'monitor', 'primary_key': 'id'}, '$schema': 'http://json-schema.org/draft-07/schema#', 'additionalProperties': True, 'name': 'monitors', ...}
format_checker = <FormatChecker checkers=['date', 'email', 'idn-email', 'idn-hostname', 'ipv4', 'ipv6', 'regex']>

bleonard avatar Apr 26 '24 04:04 bleonard

@bleonard this seems like the same issue we discussed on slack here right? Inline schema loader not playing nicely with $parameters when on an old CDK version

lmossman avatar Apr 29 '24 15:04 lmossman

I think this is different. For the most part the other issue went away when I upgraded to 0.80.0

bleonard avatar Apr 29 '24 18:04 bleonard

Oh, I saw that the manifest.yaml in this PR still had version: "0.29.0" so I thought it hadn't been upgraded

lmossman avatar Apr 29 '24 21:04 lmossman