airbyte
airbyte copied to clipboard
✨Source Outreach: Migrate Python CDK to Low-code CDK
What
Migrating Source Outreach to Low-Code CDK Closes airbytehq/airbyte-internal-issues#6916
How
Developed using (Configuration Based Source) low-code CDK
Recommended reading order
-
spec.yaml
-
manifest.yaml
-
schemas/*
Tests
Integration & Acceptance
- Test successful with incremental syncs
🚨 User Impact 🚨
- Migration to low-code
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
airbyte-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 17, 2024 3:20pm |
Inline schema :white_check_mark: Poetry lock file ✅ Breaking change referred in metadata :white_check_mark: Add migration.md docs file :white_check_mark: Docs updated ✅ Formatted :white_check_mark:
airbyte-ci test
- All pass
Marking PR as ready to merge
@btkcodedev can you run airbyte-ci format fix all
to fix the formatting issues?
Done @girarda !!
@lazebnyi,
-
those schemas looks exactly the same as previous version json, Could you please look again where is the fault, the connection looks good in local and also in Airbyte ci to,
-
There is a schema change from backend in sequence_steps_schema where changed its ['properties']['creator']['items']['type'] field to include integers, some of them are integers instead of strings
-
As the scope are not defined in the previous version and is hardcoded, user may need to access the resources, so for safety I've included all the scopes necessary for the streams.
@btkcodedev
- Ok, I'll check and get back to you.
- In that way we need use string in schema and use TypeTransformer for integers
- However, having all scopes is not necessary to sync a specific stream. By default, the availability check will filter the stream if it's not accessible to the user.
@lazebnyi Any updates🙂
@btkcodedev Please check my comment above.
You need update schema and use TypeTransformer and delete scopes list in the code as it is not require to have all scopes to start sync for some special streams.
@lazebnyi,
-
The Schema look good, and it already includes all the mentioned fields in https://github.com/airbytehq/airbyte/pull/36954#pullrequestreview-2002425832
-
There is no need for TypeTransformation not needed as it includes only integers instead of strings,
-
Scope has been reset according to the given LastPass notes
-> The connection is failing as the refresh token is expired I think, The creds need to be refreshed
@lazebnyi Scopes has been reset to the ones in LastPass, Connection check and all other checks are passing in the CI, Schema looks same as mentioned, Please continue the merge process
CI Passed perfectly
/format-fix
Format-fix job started... Check job output.
✅ Changes applied successfully. (263f800b7dfe93993428f5dccc367618ae86db4b)
@lazebnyi, Resolved comments and CI green :white_check_mark: Ready to merge :bow:
@katmarkham, Docs checked, Ready for the approval :bow: