airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Published 20 hours ago • verified publisher icon airbytehq

Java CDK: DV2 tests have separate testcases for safe_cast

Open edgao opened this issue 10 months ago • 2 comments

ported from https://github.com/airbytehq/airbyte/pull/34616.

Mysql DV2 won't have a safe_cast implementation, so we need to update tests to support crashing on CAST failures.

BaseSqlGeneratorIntegrationTest now requires implementations to specify whether they support safe casting, and its test cases have been updated to reflect this.

BaseTypingDedupingTest no longer exercises safe casting at all, under the assumption that the sqlgenerator test is sufficient coverage.

e.g. https://github.com/airbytehq/airbyte/pull/34613 to update Redshift to the new fixtures. Other connectors should look pretty similar.

edgao avatar Apr 09 '24 17:04 edgao

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 3, 2024 8:08pm

vercel[bot] avatar Apr 09 '24 17:04 vercel[bot]

  • #36935 Graphite: 6 dependent PRs (#34611 Graphite, #34612 Graphite, #34613 Graphite and 3 others) 👈
  • #36929 Graphite
  • #36926 Graphite
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @edgao and the rest of your teammates on Graphite Graphite

edgao avatar Apr 11 '24 23:04 edgao

/publish-java-cdk

:clock2: https://github.com/airbytehq/airbyte/actions/runs/8944339305 :white_check_mark: Successfully published Java CDK version=0.33.0!

edgao avatar May 03 '24 20:05 edgao