airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

✨[source-freshcaller] add `life_cycle` to `call_metrics` stream

Open DDynamic opened this issue 11 months ago • 5 comments

What

Include the life_cycle object in the call metrics stream. Remove has_ancestry query parameter as it is not present on the Freshcaller API. I am guessing it was leftover from the connector freshcaller was originally copied from.

https://developers.freshcaller.com/api/#call_metric_life_cycle_object

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

DDynamic avatar Mar 07 '24 17:03 DDynamic

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jul 8, 2024 6:22pm

vercel[bot] avatar Mar 07 '24 17:03 vercel[bot]

Sorry the lack of updates @DDynamic I'm going to take a look during the week to get your contribution merged.

marcosmarxm avatar Mar 19 '24 15:03 marcosmarxm

@marcosmarxm were you able to find anything here or did you need me to take a look?

DDynamic avatar Mar 28 '24 02:03 DDynamic

@marcosmarxm bumping

DDynamic avatar Apr 08 '24 13:04 DDynamic

@DDynamic in my todo list. Hope to get updates this week.

marcosmarxm avatar Apr 28 '24 18:04 marcosmarxm

@natikgadzhi are we still waiting on https://github.com/airbytehq/airbyte/pull/38457 to merge this?

DDynamic avatar Jun 04 '24 21:06 DDynamic

Thank you for the ping!

Yep, I'd prefer to ship the migration first, and we've shipped most of them, so it should be done soon.

natikgadzhi avatar Jun 04 '24 23:06 natikgadzhi

Hey @natikgadzhi - I just pulled from master - could I get check a ✅ now?

DDynamic avatar Jul 08 '24 15:07 DDynamic

Oh hey! Kicked the tires on CI

natikgadzhi avatar Jul 08 '24 17:07 natikgadzhi

@natikgadzhi just fixed pyproject.toml - sorry about that! I should have also got to your inline comments. Lastly, my changelog note is:

✨ Source: add life_cycletocall_metrics stream

life_cycle is a new field available on the call metrics stream from the Freshcaller API - just needed to pass an additional request parameter to the API to include it.

DDynamic avatar Jul 08 '24 18:07 DDynamic

Hello your feedback matters a lot to us. Can you spare just 3 minutes to complete a survey? We’re dedicated to making the contributor experience even better, and your input is key to achieving excellence. Thank you for helping us improve!

marcosmarxm avatar Jul 08 '24 19:07 marcosmarxm