✨ Source Klaviyo: Add `Campaign Messages` `Flow Actions` `Flow Messages` streams
What
- Add
Campaign MessagesFlow ActionsFlow Messagesstreams to source klaviyo
How
- Introduce a base class
KlaviyoSubStreamfor working with the nested Klaviyo API which has a parent entity, using theHttpSubStream - Introduce
Campaign MessagesFlow ActionsFlow Messagesstreams based onKlaviyoSubStream
Recommended reading order
airbyte-integrations/connectors/source-klaviyo/source_klaviyo/streams.pyairbyte-integrations/connectors/source-klaviyo/source_klaviyo/source.pyairbyte-integrations/connectors/source-klaviyo/unit_tests/test_streams.py
User Impact
- Add
Campaign MessagesFlow ActionsFlow Messagesstreams - No breaking changes
Pre-merge Actions
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
- Grant edit access to maintainers (instructions)
- Unit & integration tests added
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
- Create a non-forked branch based on this PR and test the below items on it
- Build is successful
- If new credentials are required for use in CI, add them to GSM. Instructions.
Before Merging a Connector Pull Request
Wow! What a great pull request you have here! 🎉
To merge this PR, ensure the following has been done/considered for each connector added or updated:
- [ ] PR name follows PR naming conventions
- [ ] Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
- [ ] Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
- [ ] You've updated the connector's
metadata.yamlfile any other relevant changes, including abreakingChangesentry for major version bumps. See metadata.yaml docs - [ ] Secrets in the connector's spec are annotated with
airbyte_secret - [ ] All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
- [ ] Changelog updated in
docs/integrations/<source or destination>/<name>.mdwith an entry for the new version. See changelog example - [ ] Migration guide updated in
docs/integrations/<source or destination>/<name>-migrations.mdwith an entry for the new version, if the version is a breaking change. See migration guide example - [ ] If set, you've ensured the icon is present in the
platform-internalrepo. (Docs)
If the checklist is complete, but the CI check is failing,
-
Check for hidden checklists in your PR description
-
Toggle the github label
checklist-action-runon/off to re-run the checklist CI.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| airbyte-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 24, 2024 6:58am |
Hello @airt thanks for contribution. I took a quick look and the implementation looks good. Now the connector team need to do the final review to measure impact and how to release the change. I ask you patience during the review process sometimes it can be quite difficult for certified connectors (the team need to ensure the change won't break existing connections or introduces bugs). Before start the review, are you able to resolve the existing conflicts?
Hello @airt thanks for contribution. I took a quick look and the implementation looks good. Now the connector team need to do the final review to measure impact and how to release the change. I ask you patience during the review process sometimes it can be quite difficult for certified connectors (the team need to ensure the change won't break existing connections or introduces bugs). Before start the review, are you able to resolve the existing conflicts?
@marcosmarxm conflicts resolved
@askarpets @lazebnyi can you take a look in this pull request please
@marcosmarxm this connector is currently being migrated to low-code. Can we wait until the migration is merged and after that add these new streams please?
@askarpets sure! I'll let this in the backlog for now.
Hello @airt, could you please resolve conflicts in this PR?
Hello @airt, could you please resolve conflicts in this PR?
done
So Campaign Messages and Flow Messages are already available?