airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Destination snowflake: Update to latest cdk

Open edgao opened this issue 1 year ago • 3 comments

lots of the same stuff as https://github.com/airbytehq/airbyte/pull/36910, might be easier to get that merged first

there's some tests still failing, didn't really look into it (they're all in SnowflakeSqlGeneratorIntegrationTest)

edgao avatar Jan 29 '24 16:01 edgao

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 10:43pm

vercel[bot] avatar Jan 29 '24 16:01 vercel[bot]

  • #34612 Graphite 👈
  • #36935 Graphite: 5 other dependent PRs (#34611 Graphite, #34613 Graphite, #36936 Graphite and 2 others)
  • #36929 Graphite
  • #36926 Graphite
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @edgao and the rest of your teammates on Graphite Graphite

edgao avatar Jan 29 '24 16:01 edgao

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • [ ] PR name follows PR naming conventions
  • [ ] Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • [ ] Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • [ ] You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • [ ] Secrets in the connector's spec are annotated with airbyte_secret
  • [ ] All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • [ ] Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • [ ] Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • [ ] If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

github-actions[bot] avatar Jan 29 '24 16:01 github-actions[bot]