airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

✨ Source S3: add options to specify region name

Open maztohir opened this issue 1 year ago • 2 comments

What

Now user can specify Bucket Region name if boto can't resolve the region name automatically

How

Add bucket_region_name in the config.py, then expose it to boto client.

Recommended reading order

  1. airbyte-integrations/connectors/source-s3/source_s3/v4/config.py
  2. airbyte-integrations/connectors/source-s3/source_s3/v4/stream_reader.py

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? NO

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

maztohir avatar Dec 26 '23 07:12 maztohir

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2023 2:16pm

vercel[bot] avatar Dec 26 '23 07:12 vercel[bot]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • [ ] PR name follows PR naming conventions
  • [ ] Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • [ ] Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • [ ] You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • [ ] Secrets in the connector's spec are annotated with airbyte_secret
  • [ ] All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • [ ] Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • [ ] Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • [ ] If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

github-actions[bot] avatar Dec 26 '23 07:12 github-actions[bot]

@maztohir , Could you please update your branch to the latest version? It would be best if you also populated the AWS region for the IAM client.

tolik0 avatar Feb 01 '24 19:02 tolik0

Closing as a duplicate of https://github.com/airbytehq/airbyte/pull/31701

tolik0 avatar Feb 02 '24 12:02 tolik0