airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

✨CAT: Add test to ensure all file types covered

Open askarpets opened this issue 2 years ago • 2 comments

What

Add a CAT to ensure all file types covered Resolves https://github.com/airbytehq/airbyte/issues/33363

How

Describe the solution

Recommended reading order

  1. test_core.py
  2. config.py

🚨 User Impact 🚨

No breaking changes

Pre-merge Actions

Updating the Python CDK

Airbyter

Before merging:

  • Pull Request description explains what problem it is solving
  • Code change is unit tested
  • Build and my-py check pass
  • Smoke test the change on at least one affected connector
    • On Github: Run this workflow, passing --use-local-cdk --name=source-<connector> as options
    • Locally: airbyte-ci connectors --use-local-cdk --name=source-<connector> test
  • PR is reviewed and approved

After merging:

  • Publish the CDK
    • The CDK does not follow proper semantic versioning. Choose minor if this the change has significant user impact or is a breaking change. Choose patch otherwise.
    • Write a thoughtful changelog message so we know what was updated.
  • Merge the platform PR that was auto-created for updating the Connector Builder's CDK version
    • This step is optional if the change does not affect the connector builder or declarative connectors.

askarpets avatar Dec 22 '23 13:12 askarpets

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 26, 2024 10:36am

vercel[bot] avatar Dec 22 '23 13:12 vercel[bot]

[!WARNING] Soft code freeze is in effect until 2024-01-02. Please avoid merging to master. #freedom-and-responsibility

github-actions[bot] avatar Dec 22 '23 13:12 github-actions[bot]