airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

🐛Source Amazon Seller Partner: improve report streams performance

Open askarpets opened this issue 2 years ago • 3 comments

What

Resolves https://github.com/airbytehq/alpha-beta-issues/issues/2495

How

Remove availability strategy for the report-based streams and replace it with try/except block which handles HTTP error 403 on _create_report request

Recommended reading order

  1. streams.py

🚨 User Impact 🚨

No breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

askarpets avatar Dec 22 '23 08:12 askarpets

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Dec 28, 2023 4:14pm

vercel[bot] avatar Dec 22 '23 08:12 vercel[bot]

[!WARNING] 🚨 Connector code freeze is in effect until 2024-01-02. This PR is changing connector code. Please contact the current OC engineers if you want to merge this change to master.

github-actions[bot] avatar Dec 22 '23 08:12 github-actions[bot]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • [x] PR name follows PR naming conventions
  • [x] Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • [x] Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • [x] You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • [x] Secrets in the connector's spec are annotated with airbyte_secret
  • [x] All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • [x] Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • [x] Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • [x] If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

github-actions[bot] avatar Dec 22 '23 08:12 github-actions[bot]