airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Icon library in storybook out of date

Open teallarson opened this issue 1 year ago • 2 comments

The hosted icon library + local storybook builds are both missing a few icons (both in the dropdown of the main story and in the nice table in the icon docs)

We have an amazing new icon library! Let's get it pushed to everywhere :)

teallarson avatar Dec 15 '23 19:12 teallarson

refining notes:

  • icons table & storybook controls dropdown are generated from typescript types -> docgen, this is usually a packager cache issue

relates to https://github.com/airbytehq/airbyte-internal-issues/issues/6197 for publishing to https://components.airbyte.dev/

chandlerprall avatar Dec 18 '23 16:12 chandlerprall

I am unable to reproduce this locally. After modifying icon & its types file, the storybook UI will often not include the changes but restarting the storybook server seems to always find the changes and rebuild correctly.

chandlerprall avatar Dec 28 '23 18:12 chandlerprall

Closing because this cannot be reproduced!

josephkmh avatar Jan 29 '24 16:01 josephkmh