airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

:sparkles: Source AppsFlyer : Migrate Python CDK to Low-code CDK

Open RealChrisSean opened this issue 1 year ago • 15 comments

https://docs.airbyte.com/integrations/sources/appsflyer

Rules for the Connectors Hackathon You can only work on one connector at a time Make sure to resolve all suggestions from the Airbyte team Must include all streams of the connector you’re migrating. Otherwise, it will not be accepted. If you don’t commit anything within five days, the issue may be assigned to someone else.

RealChrisSean avatar Jul 10 '23 21:07 RealChrisSean

Hello this has been assigned to you. You can learn more about our low-code/no-code docs here: https://airbyte.com/solutions/connector-development-kit

You can find more information on our landing page: https://airbyte.com/community/connector-hackathon

Good luck!

RealChrisSean avatar Aug 01 '23 18:08 RealChrisSean

i want to give it a try

parthiv11 avatar Aug 07 '23 15:08 parthiv11

Good luck this has been assigned to you :)

RealChrisSean avatar Aug 07 '23 17:08 RealChrisSean

Sorry @RealChrisSean , I am not familiar with AppsFlyer and it seems difficult to setup demo account for test creds.

parthiv11 avatar Aug 15 '23 08:08 parthiv11

@RealChrisSean Would like to give this a try.

anjshrg avatar Aug 31 '23 05:08 anjshrg

I would like to give this a try.

KimuchuJr avatar Oct 12 '23 18:10 KimuchuJr

Has been more than 5 days and no commits have come through so I am unassigning. This is now open!

justinbchau avatar Oct 18 '23 18:10 justinbchau

@justinbchau I want to work on this.

abu-hasib avatar Oct 19 '23 16:10 abu-hasib

hey @justinbchau, I'm getting this error when i try to run python3 main.py spec

Traceback (most recent call last):
  File "/Users/thisbo/oss/airbyte/airbyte-integrations/connectors/source-appsflyer/main.py", line 9, in <module>
    from source_appsflyer import SourceAppsflyer
  File "/Users/thisbo/oss/airbyte/airbyte-integrations/connectors/source-appsflyer/source_appsflyer/__init__.py", line 6, in <module>
    from .source import SourceAppsflyer
  File "/Users/thisbo/oss/airbyte/airbyte-integrations/connectors/source-appsflyer/source_appsflyer/source.py", line 5, in <module>
    from airbyte_cdk.sources.declarative.yaml_declarative_source import YamlDeclarativeSource
  File "/Users/thisbo/oss/airbyte/airbyte-integrations/connectors/source-appsflyer/.venv/lib/python3.11/site-packages/airbyte_cdk/sources/declarative/yaml_declarative_source.py", line 8, in <module>
    from airbyte_cdk.sources.declarative.manifest_declarative_source import ManifestDeclarativeSource
  File "/Users/thisbo/oss/airbyte/airbyte-integrations/connectors/source-appsflyer/.venv/lib/python3.11/site-packages/airbyte_cdk/sources/declarative/manifest_declarative_source.py", line 27, in <module>
    from airbyte_cdk.sources.declarative.parsers.model_to_component_factory import ModelToComponentFactory
  File "/Users/thisbo/oss/airbyte/airbyte-integrations/connectors/source-appsflyer/.venv/lib/python3.11/site-packages/airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py", line 16, in <module>
    from airbyte_cdk.sources.declarative.auth.token import (
  File "/Users/thisbo/oss/airbyte/airbyte-integrations/connectors/source-appsflyer/.venv/lib/python3.11/site-packages/airbyte_cdk/sources/declarative/auth/token.py", line 12, in <module>
    from airbyte_cdk.sources.declarative.auth.token_provider import TokenProvider
  File "/Users/thisbo/oss/airbyte/airbyte-integrations/connectors/source-appsflyer/.venv/lib/python3.11/site-packages/airbyte_cdk/sources/declarative/auth/token_provider.py", line 31, in <module>
    @dataclass
     ^^^^^^^^^
  File "/usr/local/Cellar/[email protected]/3.11.2_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/dataclasses.py", line 1220, in dataclass
    return wrap(cls)
           ^^^^^^^^^
  File "/usr/local/Cellar/[email protected]/3.11.2_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/dataclasses.py", line 1210, in wrap
    return _process_class(cls, init, repr, eq, order, unsafe_hash,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/Cellar/[email protected]/3.11.2_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/dataclasses.py", line 958, in _process_class
    cls_fields.append(_get_field(cls, name, type, kw_only))
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/Cellar/[email protected]/3.11.2_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/dataclasses.py", line 815, in _get_field
    raise ValueError(f'mutable default {type(f.default)} for field '
ValueError: mutable default <class 'airbyte_cdk.sources.declarative.decoders.json_decoder.JsonDecoder'> for field _decoder is not allowed: use default_factory

abu-hasib avatar Oct 22 '23 16:10 abu-hasib

nothing from the searches so far

abu-hasib avatar Oct 22 '23 16:10 abu-hasib

@RealChrisSean

abu-hasib avatar Oct 24 '23 12:10 abu-hasib

@abu-hasib I ran into the same issue, did you ever end up resolving it?

jonwihl avatar Nov 20 '23 21:11 jonwihl

Same problem here.

maver1ck avatar Dec 27 '23 10:12 maver1ck

@abu-hasib it should be fixed by https://github.com/airbytehq/airbyte/pull/33798

maver1ck avatar Dec 27 '23 14:12 maver1ck

@maver1ck @abu-hasib issue is because appsflyer API returns a CSV. Can you please help me understand how #33798 will help in this case?

anjshrg avatar Dec 27 '23 15:12 anjshrg

@abu-hasib this could also be related due the fact you used python 3.11.x using python 3.10.14 did not gave me an error.

Jeroendevr avatar Jul 02 '24 11:07 Jeroendevr