airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Published 20 hours ago • verified publisher icon airbytehq

Normalization: Revert to protocol v0

Open edgao opened this issue 2 years ago • 7 comments

What

Downgrades main branch to revert protocol v0 normalization changes

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • [ ] Community member? Grant edit access to maintainers (instructions)
  • [ ] Secrets in the connector's spec are annotated with airbyte_secret
  • [ ] Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • [ ] Code reviews completed
  • [ ] Documentation updated
    • [ ] Connector's README.md
    • [ ] Connector's bootstrap.md. See description and examples
    • [ ] docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • [ ] docs/integrations/README.md
    • [ ] airbyte-integrations/builds.md
  • [ ] PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • [ ] Create a non-forked branch based on this PR and test the below items on it
  • [ ] Build is successful
  • [ ] If new credentials are required for use in CI, add them to GSM. Instructions.
  • [ ] /test connector=connectors/<name> command is passing
  • [ ] New Connector version released on Dockerhub by running the /publish command described here
  • [ ] After the connector is published, connector added to connector index as described here
  • [ ] Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • [ ] Grant edit access to maintainers (instructions)
  • [ ] Secrets in the connector's spec are annotated with airbyte_secret
  • [ ] Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • [ ] Code reviews completed
  • [ ] Documentation updated
    • [ ] Connector's README.md
    • [ ] Connector's bootstrap.md. See description and examples
    • [ ] Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • [ ] PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • [ ] Create a non-forked branch based on this PR and test the below items on it
  • [ ] Build is successful
  • [ ] If new credentials are required for use in CI, add them to GSM. Instructions.
  • [ ] /test connector=connectors/<name> command is passing
  • [ ] New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • [ ] Issue acceptance criteria met
  • [ ] PR name follows PR naming conventions
  • [ ] If adding a new generator, add it to the list of scaffold modules being tested
  • [ ] The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • [ ] Documentation which references the generator is updated as needed

edgao avatar Feb 02 '23 00:02 edgao

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (0)
Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

❌ Destinations (16)
Connector Version Changelog Publish
destination-bigquery 1.2.13 ✅ ✅
destination-bigquery-denormalized 1.2.12 ✅ ❌
(diff seed version)
destination-clickhouse 0.2.2 ❌
(changelog missing)		 ✅
destination-clickhouse-strict-encrypt 0.2.2 🔵
(ignored)		 🔵
(ignored)
destination-jdbc 0.3.14 🔵
(ignored)		 🔵
(ignored)
destination-mssql 0.1.22 ✅ ✅
destination-mssql-strict-encrypt 0.1.22 🔵
(ignored)		 🔵
(ignored)
destination-mysql 0.1.20 ✅ ✅
destination-mysql-strict-encrypt ❌ 0.1.21
(mismatch: 0.1.20)		 🔵
(ignored)		 🔵
(ignored)
destination-oracle 0.1.19 ✅ ✅
destination-oracle-strict-encrypt 0.1.19 🔵
(ignored)		 🔵
(ignored)
destination-postgres 0.3.26 ✅ ✅
destination-postgres-strict-encrypt 0.3.26 🔵
(ignored)		 🔵
(ignored)
destination-redshift 0.3.56 ✅ ✅
destination-snowflake 0.4.47 ✅ ✅
destination-tidb 0.1.0 ✅ ✅
  • See "Actionable Items" below for how to resolve warnings and errors.

👀 Other Modules (1)
  • base-normalization

Actionable Items

(click to expand)
Category Status Actionable Item
Version ❌
mismatch		 The version of the connector is different from its normal variant. Please bump the version of the connector.
⚠
doc not found		 The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog ⚠
doc not found		 The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
❌
changelog missing		 There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish ⚠
not in seed		 The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
❌
diff seed version		 The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

github-actions[bot] avatar Feb 02 '23 00:02 github-actions[bot]

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.51% :x:

github-actions[bot] avatar Feb 02 '23 01:02 github-actions[bot]

Platform Test Results

   243 files  ±0     243 suites  ±0   22m 37s :stopwatch: -42s 1 663 tests ±0  1 652 :heavy_check_mark: ±0  11 :zzz: ±0  0 :x: ±0  1 682 runs  ±0  1 671 :heavy_check_mark: ±0  11 :zzz: ±0  0 :x: ±0 

Results for commit e54ccafb. ± Comparison against base commit aa5ed6dd.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 02 '23 01:02 github-actions[bot]

Kube Test Results

  47 files  ±0    47 suites  ±0   19m 17s :stopwatch: + 10m 2s 208 tests ±0  202 :heavy_check_mark: +30  6 :zzz:  - 30  0 :x: ±0  226 runs  ±0  220 :heavy_check_mark: +30  6 :zzz:  - 30  0 :x: ±0 

Results for commit e54ccafb. ± Comparison against base commit aa5ed6dd.

This pull request skips 3 and un-skips 33 tests. 
io.airbyte.test.acceptance.ContainerOrchestratorAcceptanceTests ‑ testCancelSyncWhenCancelledWhenWorkerIsNotRunning()
io.airbyte.test.acceptance.ContainerOrchestratorAcceptanceTests ‑ testCancelSyncWithInterruption()
io.airbyte.test.acceptance.ContainerOrchestratorAcceptanceTests ‑ testDowntimeDuringSync()

io.airbyte.test.acceptance.BasicAcceptanceTests ‑ testCancelSync()
io.airbyte.test.acceptance.BasicAcceptanceTests ‑ testCreateConnection()
io.airbyte.test.acceptance.BasicAcceptanceTests ‑ testCreateDestination()
io.airbyte.test.acceptance.BasicAcceptanceTests ‑ testCronSync()
io.airbyte.test.acceptance.BasicAcceptanceTests ‑ testDeleteConnection()
io.airbyte.test.acceptance.BasicAcceptanceTests ‑ testDestinationCheckConnection()
io.airbyte.test.acceptance.BasicAcceptanceTests ‑ testDiscoverSourceSchema()
io.airbyte.test.acceptance.BasicAcceptanceTests ‑ testFailedGet404()
io.airbyte.test.acceptance.BasicAcceptanceTests ‑ testGetDestinationSpec()
io.airbyte.test.acceptance.BasicAcceptanceTests ‑ testGetSourceSpec()
…

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 02 '23 01:02 github-actions[bot]

/test connector=bases/base-normalization

:clock2: bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/4070976155 :x: bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/4070976155 :bug: https://gradle.com/s/sgbqwprgoe7gu

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 SKIPPED [1] integration_tests/test_drop_scd_overwrite.py:56: DestinationType.ORACLE does not support incremental sync with schema change yet
	 SKIPPED [1] integration_tests/test_drop_scd_overwrite.py:56: DestinationType.TIDB does not support incremental sync with schema change yet
	 SKIPPED [3] integration_tests/test_ephemeral.py:102: ephemeral materialization isn't supported in ClickHouse yet
	 SKIPPED [1] integration_tests/test_ephemeral.py:59: Skipping test for column limit, because in MySQL, the max number of columns is limited by row size (8KB)
	 SKIPPED [1] integration_tests/test_normalization.py:82: Destinations DestinationType.CLICKHOUSE does not support nested streams
	 SKIPPED [1] integration_tests/test_normalization.py:144: DestinationType.CLICKHOUSE is disabled as it doesnt support schema change in incremental yet (column type changes)
	 SKIPPED [1] integration_tests/test_normalization.py:147: DestinationType.MSSQL is disabled as it doesnt fully support schema change in incremental yet
	 SKIPPED [2] integration_tests/test_normalization.py:135: DestinationType.MYSQL does not support incremental yet
	 SKIPPED [1] integration_tests/test_normalization.py:82: Destinations DestinationType.ORACLE does not support nested streams
	 SKIPPED [1] integration_tests/test_normalization.py:135: DestinationType.ORACLE does not support incremental yet
	 SKIPPED [1] integration_tests/test_normalization.py:144: DestinationType.SNOWFLAKE is disabled as it doesnt support schema change in incremental yet (column type changes)
	 SKIPPED [1] integration_tests/test_normalization.py:144: DestinationType.TIDB is disabled as it doesnt support schema change in incremental yet (column type changes)
	 FAILED integration_tests/test_drop_scd_overwrite.py::test_reset_scd_on_overwrite[DestinationType.REDSHIFT]
	 FAILED integration_tests/test_ephemeral.py::test_destination_supported_limits[DestinationType.REDSHIFT-1000]
	 FAILED integration_tests/test_ephemeral.py::test_destination_failure_over_limits[Redshift-1665-target lists can have at most 1664 entries]
	 FAILED integration_tests/test_ephemeral.py::test_empty_streams[DestinationType.REDSHIFT]
	 FAILED integration_tests/test_ephemeral.py::test_stream_with_1_airbyte_column[DestinationType.REDSHIFT]
	 FAILED integration_tests/test_normalization.py::test_normalization[DestinationType.REDSHIFT-test_nested_streams]
	 FAILED integration_tests/test_normalization.py::test_normalization[DestinationType.REDSHIFT-test_simple_streams]
	 FAILED integration_tests/test_normalization.py::test_redshift_normalization_migration
	 [31m============ [31m[1m8 failed[0m, [32m39 passed[0m, [33m15 skipped[0m[31m in 2886.31s (0:48:06)[0m[31m =============[0m

edgao avatar Feb 02 '23 03:02 edgao

/test connector=connectors/destination-snowflake

:clock2: connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/4071063342 :white_check_mark: connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/4071063342 Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         189     48    75%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 595    400    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1441    629    56%

Build Passed

Test summary info:

All Passed

edgao avatar Feb 02 '23 03:02 edgao

/test connector=connectors/destination-bigquery

:clock2: connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/4071357377 :white_check_mark: connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/4071357377 Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         189     48    75%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 595    400    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1441    629    56%

Build Passed

Test summary info:

All Passed

edgao avatar Feb 02 '23 04:02 edgao