airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Fixes for state storage env vars

Open adam-bloom opened this issue 2 years ago • 0 comments

What

  • The current env var checks for state storage do not properly exclude empty env vars, as is currently implemented for log storage. This means that it is impossible to configure S3 state storage using both kustomize and helm, as those define env vars for the minio state storage (even when they are empty)
  • S3 state storage had two different env vars used for region

How

  • Borrows the same logic pattern from log storage to apply to state storage
  • Consolidate to a single env var for S3 state storage region (these env vars are not currently set by either kustomize or helm)

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

adam-bloom avatar Feb 01 '23 01:02 adam-bloom