airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Source freshdesk: deduplicate table names

Open davydov-d opened this issue 2 years ago • 4 comments

What

https://github.com/airbytehq/oncall/issues/1339

How

There's a nested object called business_hours in the business_hours stream. When normalization comes into action, there's a name collision so one of the tables has to be renamed

davydov-d avatar Jan 31 '23 19:01 davydov-d

/test connector=connectors/source-freshdesk

:clock2: connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/4057723122

davydov-d avatar Jan 31 '23 19:01 davydov-d

/test connector=connectors/source-freshdesk

:clock2: connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/4057780052 :x: connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/4057780052 :bug: https://gradle.com/s/uhhx6p2gamgae

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream conta...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
============= 1 failed, 35 passed, 1 skipped in 346.37s (0:05:46) ==============

davydov-d avatar Jan 31 '23 19:01 davydov-d

/test connector=connectors/source-freshdesk

:clock2: connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/4062546964 :x: connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/4062546964 :bug: https://gradle.com/s/m7lysjo7j6gmy

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream conta...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
============= 1 failed, 35 passed, 1 skipped in 358.64s (0:05:58) ==============

davydov-d avatar Feb 01 '23 08:02 davydov-d

/test connector=connectors/source-freshdesk

:clock2: connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/4064107866 :white_check_mark: connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/4064107866 Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_freshdesk/source.py        31      0   100%
source_freshdesk/__init__.py       2      0   100%
source_freshdesk/streams.py      229      4    98%
source_freshdesk/utils.py         20      1    95%
--------------------------------------------------
TOTAL                            282      5    98%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
================== 36 passed, 1 skipped in 351.47s (0:05:51) ===================

davydov-d avatar Feb 01 '23 12:02 davydov-d

/publish connector=connectors/source-freshdesk

:clock2: Publishing the following connectors:
connectors/source-freshdesk
https://github.com/airbytehq/airbyte/actions/runs/4102438203

Connector Did it publish? Were definitions generated?
connectors/source-freshdesk :white_check_mark: :white_check_mark:

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

davydov-d avatar Feb 06 '23 09:02 davydov-d

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.52% :x:

github-actions[bot] avatar Feb 06 '23 10:02 github-actions[bot]

/approve-and-merge reason="On-call related connector release scheduled for Feb 06 10 AM EST"

davydov-d avatar Feb 06 '23 15:02 davydov-d

It's time
fine lets go

octavia-approvington avatar Feb 06 '23 15:02 octavia-approvington