airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

🎉 New Source: the-forex-api

Open olivermeyer opened this issue 3 years ago • 2 comments

What

Creating a new source for the-forex-api using the low-code CDK.

Pre-merge Checklist

Community member or Airbyter

  • [x] Community member? Grant edit access to maintainers (instructions)
  • [ ] Secrets in the connector's spec are annotated with airbyte_secret
  • [ ] Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • [ ] Code reviews completed
  • [ ] Documentation updated
    • [x] Connector's README.md
    • [ ] Connector's bootstrap.md. See description and examples
    • [x] docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • [ ] docs/integrations/README.md
    • [ ] airbyte-integrations/builds.md
  • [x] PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • [ ] Create a non-forked branch based on this PR and test the below items on it
  • [ ] Build is successful
  • [ ] If new credentials are required for use in CI, add them to GSM. Instructions.
  • [ ] /test connector=connectors/<name> command is passing
  • [ ] New Connector version released on Dockerhub by running the /publish command described here
  • [ ] After the connector is published, connector added to connector index as described here
  • [ ] Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

olivermeyer avatar Jan 31 '23 11:01 olivermeyer

Various integration tests are failing. Some of them expect a spec.yaml file, but my understanding is that it's not required since the spec is now in the manifest.yaml. test_read is failing with the following error

    @staticmethod
    def check_datetime(value: str) -> bool:
>       valid_format = timestamp_regex.match(value)
E       TypeError: expected string or bytes-like object

../../bases/source-acceptance-test/source_acceptance_test/utils/asserts.py:30: TypeError
-----------------------------------------------------------------------------------------

I'm not sure what it's trying to do. I am able to run the connector locally.

I'd appreciate some help in getting the tests to pass :)

olivermeyer avatar Jan 31 '23 12:01 olivermeyer

@marcosmarxm can you help out? Not sure who I need to tag nowadays :)

olivermeyer avatar Feb 01 '23 09:02 olivermeyer

@marcosmarxm thanks for taking a look at this! Unfortunately the API has been down since Friday, so we're going to find a more stable source for this data.

olivermeyer avatar Feb 08 '23 06:02 olivermeyer