airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Clickhouse destination connector ```check() method``` should fail when SSL options are not set

Open akashkulk opened this issue 3 years ago • 0 comments

Currently, the ClickHouse destination connector doesn't fail the check() method when a user has not enabled SSL options. While users setting up a new connection would not be able to turn off SSL, thanks to https://github.com/airbytehq/airbyte/issues/21507, the user can still get into a state with older configs where the option was disabled.

Adding this to the check method will help to catch these cases and force the user to turn on SSL. Please see https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-postgres/src/main/java/io/airbyte/integrations/source/postgres/PostgresSourceStrictEncrypt.java#L55 for an example of how to do this

akashkulk avatar Jan 28 '23 01:01 akashkulk