airbyte
airbyte copied to clipboard
Turn off default httpavailabilitystrategy for source-marketo (GA)
See https://github.com/airbytehq/airbyte/pull/21888 for description
/test connector=connectors/source-marketo
:clock2: connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4028652092 :x: connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4028652092 :bug: https://gradle.com/s/rwuxmyodblnng
Build Failed
Test summary info:
=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream progr...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
====== 1 failed, 28 passed, 2 skipped, 31 warnings in 2274.47s (0:37:54) =======
> Task :airbyte-integrations:connectors:source-marketo:sourceAcceptanceTest FAILED
Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
See https://docs.gradle.org/7.6/userguide/command_line_interface.html#sec:command_line_warnings
Execution optimizations have been disabled for 1 invalid unit(s) of work during this build to ensure correctness.
Please consult deprecation warnings for more details.
48 actionable tasks: 23 executed, 25 up-to-date
Publishing build scan...
https://gradle.com/s/rwuxmyodblnng
The remote build cache was disabled during the build due to errors.
S3 cache writes: 1, elapsed: 701ms, sent to cache: 446 B
/test connector=connectors/source-marketo
:clock2: connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4029848981 :x: connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4029848981 :bug: https://gradle.com/s/7l3ydtm4c3pcw
Build Failed
Test summary info:
=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream progr...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
====== 1 failed, 28 passed, 2 skipped, 31 warnings in 2273.91s (0:37:53) =======
> Task :airbyte-integrations:connectors:source-marketo:sourceAcceptanceTest FAILED
Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
See https://docs.gradle.org/7.6/userguide/command_line_interface.html#sec:command_line_warnings
Execution optimizations have been disabled for 1 invalid unit(s) of work during this build to ensure correctness.
Please consult deprecation warnings for more details.
48 actionable tasks: 23 executed, 25 up-to-date
Publishing build scan...
https://gradle.com/s/7l3ydtm4c3pcw
The remote build cache was disabled during the build due to errors.
S3 cache writes: 1, elapsed: 728ms, sent to cache: 448 B
Same failure as in #connector-health
Then I think it's probably OK to merge
Thanks, will do. Double-checking all others for which this is the case and posting those as well!
/publish connector=connectors/source-marketo run-tests=false
:clock2: Publishing the following connectors:
connectors/source-marketo
https://github.com/airbytehq/airbyte/actions/runs/4045182674
Connector | Did it publish? | Were definitions generated? |
---|---|---|
connectors/source-marketo | :x: | :x: |
if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️
Apparently this version was published 11 days ago without a changelog, coming back to look into it
It was released off of this PR that was never merged: https://github.com/airbytehq/airbyte/pull/20973. Seems to have been published by a contributor while skipping the tests
If I try to push a new version of the connector, I'd essentially be undoing the changes from the unmerged contributor PR for the latest version of the connector published. That would affect OSS users who upgraded to this version because they were seeing the issue linked in that PR.
However, cloud is still seeing 0.1.11, since the cloud catalog was never updated, since the PR was merged. Therefore cloud users should see no effects of going from 0.1.11 to 0.1.13. Users who want 0.1.12 in OSS can still use that version as they see fit, and then when that PR is merged, the changes will be reflected in 0.1.14 (or whatever version is next when it goes in) for both cloud and OSS users. Does that sound good @evantahler?
I suppose I'd add the changelog entry from 0.1.12 too, and make it clear that 0.1.13 reverts those changes
However, cloud is still seeing 0.1.11, since the cloud catalog was never updated, since the PR was merged. Therefore cloud users should see no effects of going from 0.1.11 to 0.1.13. Users who want 0.1.12 in OSS can still use that version as they see fit, and then when that PR is merged, the changes will be reflected in 0.1.14 (or whatever version is next when it goes in) for both cloud and OSS users. Does that sound good @evantahler?
Yep! Although, it's a shame we got into this position.
Alternatively, you could merge in https://github.com/airbytehq/airbyte/pull/20973 and then merge this after?
I would, except for the fact that the acceptance tests went from consistently succeeding to consistently failing. I think that PR needs some more work before it goes in 😕 will run tests on that branch
Actually, now that I think about it, it seems weird that the connector would start failing tests on the #connector-health check since they're built off of master. So maybe that is actually unrelated, though it started failing on the 19th, when the new version was released... confusion abounds
Merged the contributor PR - someone had already released a newer version. Releasing this version should re-introduce the contributor's changes lost in the 1.0.0 version as well as add my changes.
/publish connector=connectors/source-marketo run-tests=false
:clock2: Publishing the following connectors:
connectors/source-marketo
https://github.com/airbytehq/airbyte/actions/runs/4058180228
Connector | Did it publish? | Were definitions generated? |
---|---|---|
connectors/source-marketo | :white_check_mark: | :white_check_mark: |
if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️
Airbyte Code Coverage
There is no coverage information present for the Files changed
Total Project Coverage | 24.51% | :x: |
---|