airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Low Code CDK: only allow `name` and `primary_key` on `DeclarativeStream` components

Open clnoll opened this issue 2 years ago • 1 comments

Closes https://github.com/airbytehq/airbyte/issues/21560.

What

Avoid duplication/simplify UX by removing the name and primary_key fields from the SimpleRetriever and HttpRequester components, which can inherit it as needed from DeclarativeStream.

Recommended reading order

  1. First commit - updates to the CDK & documentation
  2. Second commit - migration of existing manifests to remove name and primary_key from non-DeclarativeStream components.
  • [x] ./gradlew validateSourceYamlManifest is passing after updating the manifests
  • [x] Documentation which references the component is updated as needed

clnoll avatar Jan 25 '23 22:01 clnoll

@brianjlai the manifest changes were done manually, as there weren't too many. I made the suggested changes if you want to rereview.

clnoll avatar Jan 26 '23 22:01 clnoll