airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Published 20 hours ago • verified publisher icon airbytehq

Postgres source: add integration with data dog

Open sashaNeshcheret opened this issue 2 years ago • 5 comments

What

Describe what the change is solving It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • [ ] Community member? Grant edit access to maintainers (instructions)
  • [ ] Secrets in the connector's spec are annotated with airbyte_secret
  • [ ] Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • [ ] Code reviews completed
  • [ ] Documentation updated
    • [ ] Connector's README.md
    • [ ] Connector's bootstrap.md. See description and examples
    • [ ] docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • [ ] docs/integrations/README.md
    • [ ] airbyte-integrations/builds.md
  • [ ] PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • [ ] Create a non-forked branch based on this PR and test the below items on it
  • [ ] Build is successful
  • [ ] If new credentials are required for use in CI, add them to GSM. Instructions.
  • [ ] /test connector=connectors/<name> command is passing
  • [ ] New Connector version released on Dockerhub by running the /publish command described here
  • [ ] After the connector is published, connector added to connector index as described here
  • [ ] Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • [ ] Grant edit access to maintainers (instructions)
  • [ ] Secrets in the connector's spec are annotated with airbyte_secret
  • [ ] Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • [ ] Code reviews completed
  • [ ] Documentation updated
    • [ ] Connector's README.md
    • [ ] Connector's bootstrap.md. See description and examples
    • [ ] Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • [ ] PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • [ ] Create a non-forked branch based on this PR and test the below items on it
  • [ ] Build is successful
  • [ ] If new credentials are required for use in CI, add them to GSM. Instructions.
  • [ ] /test connector=connectors/<name> command is passing
  • [ ] New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • [ ] Issue acceptance criteria met
  • [ ] PR name follows PR naming conventions
  • [ ] If adding a new generator, add it to the list of scaffold modules being tested
  • [ ] The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • [ ] Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

sashaNeshcheret avatar Jan 18 '23 17:01 sashaNeshcheret

/publish connector=connectors/source-postgres

:clock2: Publishing the following connectors:
connectors/source-postgres
https://github.com/airbytehq/airbyte/actions/runs/3969946856

Connector Did it publish? Were definitions generated?
connectors/source-postgres :white_check_mark: :white_check_mark:

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

sashaNeshcheret avatar Jan 20 '23 17:01 sashaNeshcheret

/publish connector=connectors/source-postgres-strict-encrypt

:clock2: Publishing the following connectors:
connectors/source-postgres-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3971529928

Connector Did it publish? Were definitions generated?
connectors/source-postgres-strict-encrypt :white_check_mark: :x:

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

sashaNeshcheret avatar Jan 20 '23 21:01 sashaNeshcheret

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (31)
Connector Version Changelog Publish
source-alloydb 2.0.3 ✅ ✅
source-alloydb-strict-encrypt 2.0.3 🔵
(ignored)		 🔵
(ignored)
source-bigquery 0.2.3 ✅ ✅
source-clickhouse 0.1.16 ✅ ✅
source-clickhouse-strict-encrypt 0.1.16 🔵
(ignored)		 🔵
(ignored)
source-cockroachdb 0.1.21 ✅ ✅
source-cockroachdb-strict-encrypt 0.1.21 🔵
(ignored)		 🔵
(ignored)
source-db2 0.1.18 ✅ ✅
source-db2-strict-encrypt 0.1.18 🔵
(ignored)		 🔵
(ignored)
source-dynamodb 0.1.2 ✅ ✅
source-e2e-test 2.1.4 ✅ ✅
source-e2e-test-cloud 2.1.4 🔵
(ignored)		 🔵
(ignored)
source-elasticsearch 0.1.1 ✅ ✅
source-jdbc 0.3.5 🔵
(ignored)		 🔵
(ignored)
source-kafka 0.2.3 ✅ ✅
source-mongodb-strict-encrypt 0.1.19 🔵
(ignored)		 🔵
(ignored)
source-mongodb-v2 0.1.19 ✅ ✅
source-mssql 1.0.4 ✅ ✅
source-mssql-strict-encrypt 1.0.4 🔵
(ignored)		 🔵
(ignored)
source-mysql 2.0.5 ✅ ✅
source-mysql-strict-encrypt 2.0.5 🔵
(ignored)		 🔵
(ignored)
source-oracle 0.3.23 ✅ ✅
source-oracle-strict-encrypt 0.3.23 🔵
(ignored)		 🔵
(ignored)
source-postgres 2.0.5 ✅ ✅
source-postgres-strict-encrypt 2.0.5 🔵
(ignored)		 🔵
(ignored)
source-redshift 0.3.16 ✅ ✅
source-relational-db 0.3.1 🔵
(ignored)		 🔵
(ignored)
source-scaffold-java-jdbc 0.1.0 🔵
(ignored)		 🔵
(ignored)
source-sftp 0.1.2 ✅ ✅
source-snowflake 0.1.31 ✅ ✅
source-tidb 0.2.3 ✅ ✅
  • See "Actionable Items" below for how to resolve warnings and errors.

❌ Destinations (48)
Connector Version Changelog Publish
destination-azure-blob-storage 0.2.0 ✅ ✅
destination-bigquery 1.2.17 ✅ ✅
destination-bigquery-denormalized 1.2.17 ✅ ✅
destination-cassandra 0.1.4 ✅ ✅
destination-clickhouse 0.2.2 ✅ ✅
destination-clickhouse-strict-encrypt 0.2.2 🔵
(ignored)		 🔵
(ignored)
destination-csv 1.0.0 ✅ ✅
destination-databricks 1.0.0 ✅ ✅
destination-dev-null 0.2.7 🔵
(ignored)		 🔵
(ignored)
destination-doris 0.1.0 ✅ ✅
destination-dynamodb 0.1.7 ✅ ✅
destination-e2e-test 0.2.4 ✅ ✅
destination-elasticsearch 0.1.6 ✅ ✅
destination-elasticsearch-strict-encrypt 0.1.6 🔵
(ignored)		 🔵
(ignored)
destination-exasol 0.1.1 ✅ ✅
destination-gcs 0.2.16 ✅ ✅
destination-iceberg 0.1.0 ✅ ✅
destination-jdbc 0.3.14 🔵
(ignored)		 🔵
(ignored)
destination-kafka 0.1.10 ✅ ✅
destination-keen 0.2.4 ✅ ✅
destination-kinesis 0.1.5 ✅ ✅
destination-local-json 0.2.11 ✅ ✅
destination-mariadb-columnstore 0.1.7 ✅ ✅
destination-mongodb 0.1.9 ✅ ✅
destination-mongodb-strict-encrypt 0.1.9 🔵
(ignored)		 🔵
(ignored)
destination-mqtt 0.1.3 ✅ ✅
destination-mssql 0.1.22 ✅ ✅
destination-mssql-strict-encrypt 0.1.22 🔵
(ignored)		 🔵
(ignored)
destination-mysql 0.1.20 ✅ ✅
destination-mysql-strict-encrypt ❌ 0.1.21
(mismatch: 0.1.20)		 🔵
(ignored)		 🔵
(ignored)
destination-oracle 0.1.19 ✅ ✅
destination-oracle-strict-encrypt 0.1.19 🔵
(ignored)		 🔵
(ignored)
destination-postgres 0.3.26 ✅ ✅
destination-postgres-strict-encrypt 0.3.26 🔵
(ignored)		 🔵
(ignored)
destination-pubsub 0.2.0 ✅ ✅
destination-pulsar 0.1.3 ✅ ✅
destination-r2 0.1.0 ✅ ✅
destination-redis 0.1.4 ✅ ✅
destination-redpanda 0.1.0 ✅ ✅
destination-redshift 0.4.3 ✅ ✅
destination-rockset 0.1.4 ✅ ✅
destination-s3 0.3.22 ✅ ✅
destination-s3-glue 0.1.2 ✅ ✅
destination-scylla 0.1.3 ✅ ✅
destination-snowflake 0.4.54 ✅ ✅
destination-teradata 0.1.1 ✅ ✅
destination-tidb 0.1.0 ✅ ✅
destination-yugabytedb 0.1.1 ✅ ✅
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)
Category Status Actionable Item
Version ❌
mismatch		 The version of the connector is different from its normal variant. Please bump the version of the connector.
⚠
doc not found		 The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog ⚠
doc not found		 The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
❌
changelog missing		 There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish ⚠
not in seed		 The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
❌
diff seed version		 The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

github-actions[bot] avatar Jan 23 '23 20:01 github-actions[bot]

/publish connector=connectors/source-postgres-strict-encrypt

:clock2: Publishing the following connectors:
connectors/source-postgres-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/4053863057

Connector Did it publish? Were definitions generated?
connectors/source-postgres-strict-encrypt :white_check_mark: :x:

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

sashaNeshcheret avatar Jan 31 '23 12:01 sashaNeshcheret

/publish connector=connectors/source-postgres-strict-encrypt

:clock2: Publishing the following connectors:
connectors/source-postgres-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/4056333466

Connector Did it publish? Were definitions generated?
connectors/source-postgres-strict-encrypt :white_check_mark: :x:

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

sashaNeshcheret avatar Jan 31 '23 16:01 sashaNeshcheret

/publish connector=connectors/source-postgres-strict-encrypt

:clock2: Publishing the following connectors:
connectors/source-postgres-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/4256404355

Connector Did it publish? Were definitions generated?
connectors/source-postgres-strict-encrypt :white_check_mark: :x:

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

sashaNeshcheret avatar Feb 23 '23 20:02 sashaNeshcheret

/publish connector=connectors/source-postgres-strict-encrypt

:clock2: Publishing the following connectors:
connectors/source-postgres-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/4284139281

Connector Did it publish? Were definitions generated?
connectors/source-postgres-strict-encrypt :x: :x:

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

sashaNeshcheret avatar Feb 27 '23 15:02 sashaNeshcheret

/publish connector=connectors/source-postgres-strict-encrypt

:clock2: Publishing the following connectors:
connectors/source-postgres-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/4305311798

Connector Did it publish? Were definitions generated?
connectors/source-postgres-strict-encrypt :white_check_mark: :x:

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

sashaNeshcheret avatar Mar 01 '23 15:03 sashaNeshcheret

/publish connector=connectors/source-postgres-strict-encrypt

:clock2: Publishing the following connectors:
connectors/source-postgres-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/4316351861

Connector Did it publish? Were definitions generated?
connectors/source-postgres-strict-encrypt :white_check_mark: :x:

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

sashaNeshcheret avatar Mar 02 '23 16:03 sashaNeshcheret

/publish connector=connectors/source-postgres-strict-encrypt

:clock2: Publishing the following connectors:
connectors/source-postgres-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/4366258809

Connector Did it publish? Were definitions generated?
connectors/source-postgres-strict-encrypt :white_check_mark: :x:

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

sashaNeshcheret avatar Mar 08 '23 16:03 sashaNeshcheret

@sashaNeshcheret we are not going to merge this PR right (not going to release the image to cloud). I assume you published the image just for your own testing?

subodh1810 avatar Mar 08 '23 16:03 subodh1810

@sashaNeshcheret we are not going to merge this PR right (not going to release the image to cloud). I assume you published the image just for your own testing?

@subodh1810 sure, it is just for test and will be deployed on dev cloud

sashaNeshcheret avatar Mar 08 '23 16:03 sashaNeshcheret

@sashaNeshcheret cool thanks for clarifying :D

subodh1810 avatar Mar 08 '23 16:03 subodh1810

/publish connector=connectors/source-postgres-strict-encrypt

:clock2: Publishing the following connectors:
connectors/source-postgres-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/4407042047

Connector Did it publish? Were definitions generated?
connectors/source-postgres-strict-encrypt :white_check_mark: :x:

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

sashaNeshcheret avatar Mar 13 '23 16:03 sashaNeshcheret

/test connector=connectors/source-postgres-strict-encrypt

:clock2: connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/4438115782 :white_check_mark: connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/4438115782 No Python unittests run

Build Passed

Test summary info:

All Passed

sashaNeshcheret avatar Mar 16 '23 14:03 sashaNeshcheret

/test connector=connectors/source-postgres

:clock2: connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4438117186 :white_check_mark: connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4438117186 No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
=================== 62 passed, 5 skipped in 80.97s (0:01:20) ===================

sashaNeshcheret avatar Mar 16 '23 14:03 sashaNeshcheret

/publish connector=connectors/source-postgres-strict-encrypt

:clock2: Publishing the following connectors:
connectors/source-postgres-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/4438571133

Connector Did it publish? Were definitions generated?
connectors/source-postgres-strict-encrypt :white_check_mark: :x:

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

sashaNeshcheret avatar Mar 16 '23 15:03 sashaNeshcheret

Can you add the loom demoing this in the PR description? Thanks!

akashkulk avatar Mar 16 '23 16:03 akashkulk

Datadog loom

sashaNeshcheret avatar Mar 16 '23 19:03 sashaNeshcheret

/publish connector=connectors/source-postgres-strict-encrypt

:clock2: Publishing the following connectors:
connectors/source-postgres-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/4451954796

Connector Did it publish? Were definitions generated?
connectors/source-postgres-strict-encrypt :white_check_mark: :x:

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

sashaNeshcheret avatar Mar 17 '23 22:03 sashaNeshcheret

/publish connector=connectors/source-postgres

:clock2: Publishing the following connectors:
connectors/source-postgres
https://github.com/airbytehq/airbyte/actions/runs/4451957183

Connector Did it publish? Were definitions generated?
connectors/source-postgres :x: :x:

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

sashaNeshcheret avatar Mar 17 '23 22:03 sashaNeshcheret

/publish connector=connectors/source-postgres

:clock2: Publishing the following connectors:
connectors/source-postgres
https://github.com/airbytehq/airbyte/actions/runs/4454272571

Connector Did it publish? Were definitions generated?
connectors/source-postgres :x: :x:

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

sashaNeshcheret avatar Mar 18 '23 07:03 sashaNeshcheret

/test connector=connectors/source-postgres

:clock2: connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4469337602 :x: connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4469337602 :bug: https://gradle.com/s/nmfiwq2d7bqhc

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - AssertionError: All ...
FAILED test_core.py::TestBasicRead::test_read[inputs1] - AssertionError: All ...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
============== 2 failed, 60 passed, 5 skipped in 77.46s (0:01:17) ==============

sashaNeshcheret avatar Mar 20 '23 14:03 sashaNeshcheret

/test connector=connectors/source-postgres

:clock2: connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4477707761 :white_check_mark: connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4477707761 No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
=================== 62 passed, 5 skipped in 79.02s (0:01:19) ===================

sashaNeshcheret avatar Mar 21 '23 10:03 sashaNeshcheret

/publish connector=connectors/source-postgres

:clock2: Publishing the following connectors:
connectors/source-postgres
https://github.com/airbytehq/airbyte/actions/runs/4479493891

Connector Did it publish? Were definitions generated?
connectors/source-postgres :x: :x:

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

sashaNeshcheret avatar Mar 21 '23 13:03 sashaNeshcheret

/publish connector=connectors/source-postgres

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

sashaNeshcheret avatar Mar 21 '23 14:03 sashaNeshcheret

/publish connector=connectors/source-postgres-strict-encrypt

:clock2: Publishing the following connectors:
connectors/source-postgres-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/4480450140

Connector Did it publish? Were definitions generated?
connectors/source-postgres-strict-encrypt :white_check_mark: :x:

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

sashaNeshcheret avatar Mar 21 '23 14:03 sashaNeshcheret

/publish connector=connectors/source-postgres

:clock2: Publishing the following connectors:
connectors/source-postgres
https://github.com/airbytehq/airbyte/actions/runs/4481167648

Connector Did it publish? Were definitions generated?
connectors/source-postgres :white_check_mark: :white_check_mark:

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

sashaNeshcheret avatar Mar 21 '23 15:03 sashaNeshcheret