airbyte
airbyte copied to clipboard
Updated Braintree connector docs
Hi, Followed Amruta's youTube video's reference to edit Braintree's connector docs. This is my first open-source contribution!
- Added prerequisites section
- consistent header sizes
- Added set up guide (similar to Freshdesk and Greenhouse)
Following are some of the areas I did not touch because there was ambiguity there and I did not want to change anything around because of my limited knowledge of both Airbyte and Braintree:-
- The sentence "creating read-only key specifically for Airbyte access" could do well with specifying what key are we talking about exactly because there are two keys; public and private and I couldn't really find that out on my own either from google. (So, perhaps someone can edit that in the future)
- Sync Overview (I was not sure about whether all 4 kinds of syncs are being supported for Braintree from what was originally written in the docs, so I let the original sentence be as is; did not modify it one bit)
- Data type mapping (Again, I was not sure what data mapping truly meant here, so I let it be, as is)
Thanks.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.
:white_check_mark: sandip-baidya
:white_check_mark: Amruta-Ranade
:x: sandip
sandip seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
@Amruta-Ranade can you check this contribution?
Requires a tiny change, but overall, looks good! Thank you for your contribution!
Hi, I'm new to this. Just wanted to know if I have to do anything to accommodate this change you've requested, or whether that is something that you can do from your end because I couldn't exactly find the change you requested. (I know you're busy, so take your time and please let me know what the next steps are, once you're available ::)
Also, I can follow the guidelines from your video and edit all the connector docs one by one (especially the ones that have not gone through any edits at all)
Requires a tiny change, but overall, looks good! Thank you for your contribution!
Hi, I'm new to this. Just wanted to know if I have to do anything to accommodate this change you've requested, or whether that is something that you can do from your end because I couldn't exactly find the change you requested. (I know you're busy, so take your time and please let me know what the next steps are, once you're available ::)
Also, I can follow the guidelines from your video and edit all the connector docs one by one (especially the ones that have not gone through any edits at all)
Ah, sorry, the comment didn't save yesterday. Let me know if you see it now! We'd love your help with other connectors. Let's merge this PR and discuss what you can pick up next :)
Hello, Addressed your changes. Please review once from your side. And if that gets successfully done, then let's talk about other connector docs ::)
@Amruta-Ranade hello. Just wanted to check if my pull request went through successfully and if not, am I required to do something else for it to go through properly?
PS I could not figure out how to incorporate the changes you requested in the original way I edited this document (i.e. straight into GitHub) so I ended up using git to push changes from my local system, onto GitHub and I'm worried that it may not have sent properly)
@Amruta-Ranade hello. Just wanted to check if my pull request went through successfully and if not, am I required to do something else for it to go through properly?
PS I could not figure out how to incorporate the changes you requested in the original way I edited this document (i.e. straight into GitHub) so I ended up using git to push changes from my local system, onto GitHub and I'm worried that it may not have sent properly)
Thanks for the ping! The PR looks good. Can you sign the CLA with the new user id you used to push the latest change?
Hello! I am not able to sign the CLA with the new user. Turns out, when I pushed changes from my local machine, I had not explicitly linked my GitHub email with that user. Can I just open a new PR with all of the changes done till now, and delete this particular PR?
(Or I could make tiny changes, for example, removal of space or something, and push again with a user that's linked to my actual GitHub account?) Apologies for the so-many back and forth.
Hello! I am not able to sign the CLA with the new user. Turns out, when I pushed changes from my local machine, I had not explicitly linked my GitHub email with that user. Can I just open a new PR with all of the changes done till now, and delete this particular PR?
(Or I could make tiny changes, for example, removal of space or something, and push again with a user that's linked to my actual GitHub account?) Apologies for the so-many back and forth.
I asked the team what's the best course of action here. Will let you know when I hear back :)
The team recommended the second option: Make a small change and push with the correct username