Source Pipedrive - Missing Product Tables + relations

[emeagenciadigital]

Tell us about the problem you're trying to solve

What are you trying to do, and why is it hard? A clear and concise description of what the problem is. Ex. I'm always frustrated when [THere is no way to get deal products, person related fields and deal related fields]

Describe the solution you’d like

1. Add the followign missing content fron the following api endpoints:

   For missing products in deals:

   • https://developers.pipedrive.com/docs/api/v1/Products
   • https://developers.pipedrive.com/docs/api/v1/ProductFields

The next to endpoints will help discovering the relation between a deal and a product. - https://developers.pipedrive.com/docs/api/v1/Deals#getDealProducts - https://developers.pipedrive.com/docs/api/v1/Products#getProductDeals

3. For missing persons relations with custom fields: The "persons fields" table should contain the field pipedrive id, wich is named as KEY. The "persons" table should columnized the custom fields KEY.

[sajarin]

Thanks for the issue @emeagenciadigital, are you willing to create a PR with the added streams + missing relations?

[emeagenciadigital]

@sajarin I don't have the knowledge to do it myself. If it helps, for reference the singer tap of Pipedrive includes the following streams :

• Deal flow
• Deal products

[vidaletti]

@YowanR I'd like to work on this issue

[YowanR]

Any progress on this, @vidaletti? Fixed the reward for this issue as well :)

[vidaletti]

Hi @YowanR I'm already doing local tests. I believe next week I can release the PR

[emeagenciadigital]

Thanks !!! If you need testers I will be available .

On Sat, 14 Jan 2023 at 5:51 PM Sirleno Vidaletti @.***> wrote:

Hi @YowanR https://github.com/YowanR I'm already doing local tests. I believe next week I can release the PR

— Reply to this email directly, view it on GitHub https://github.com/airbytehq/airbyte/issues/19008#issuecomment-1382954357, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEJOJFO2V2YKDY3WZ6DCUVDWSMUX5ANCNFSM6AAAAAARYD4GPE . You are receiving this because you were mentioned.Message ID: @.***>

-- Daniel Vengoechea Head of Growth e-me.co

-- Pd: Conoce nuestra nueva página web www.e-me.co http://e-me.co/?utm_source=email-signature-pd&utm_medium=email&utm_campaign=email-signature-pd

[vidaletti]

hi @YowanR / @sajarin Can you check if I have permission to create the branch? Button "create branch" is not enabled? Thanks!

[YowanR]

@natalyjazzviolin @sajarin can you take a look, please?

[sajarin]

hey @vidaletti you should be able to fork the airbyte repo and push changes to a branch in your forked copy and then make a PR on our repo based on that branch. Is this the process you're using?

[vidaletti]

@sajarin yes, follow the documentation for developers and I did as below. But the return is a 403 svidaletti@Sirlenos-MacBook-Pro airbyte % git push origin pipedrive-deals-19008 remote: Permission to airbytehq/airbyte.git denied to vidaletti. fatal: unable to access 'https://github.com/airbytehq/airbyte.git/': The requested URL returned error: 403

[sajarin]

@vidaletti you should push the pipesrive-deals-19008 branch to your forked repo and then navigate to the create pull request for airbytehq/airbyte and you should be able to create a PR. Make sure you enable commit access for maintainers when creating your PR. Hope this helps.

[vidaletti]

@sajarin and @YowanR I'm sorry! I had already done the fork and made the wrong local directory and branched over the wrong repo clone. Thanks for the help and sorry for the distraction

[emeagenciadigital]

Hi @YowanR any progress on this ? Let me know if you need testers

[grubberr]

In this PR https://github.com/airbytehq/airbyte/pull/23789 I have implemented 3 additional streams discussed in this issue: Products, ProductFields, DealProducts

[grubberr]

no response from customer I think we can close it