airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Destination AWS Datalake: enable new DAT

Open yurii-bidiuk opened this issue 2 years ago • 8 comments

What

Fixes #13311

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • [ ] Community member? Grant edit access to maintainers (instructions)
  • [ ] Secrets in the connector's spec are annotated with airbyte_secret
  • [ ] Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • [ ] Code reviews completed
  • [ ] Documentation updated
    • [ ] Connector's README.md
    • [ ] Connector's bootstrap.md. See description and examples
    • [ ] docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • [ ] docs/integrations/README.md
    • [ ] airbyte-integrations/builds.md
  • [ ] PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • [ ] Create a non-forked branch based on this PR and test the below items on it
  • [ ] Build is successful
  • [ ] If new credentials are required for use in CI, add them to GSM. Instructions.
  • [ ] /test connector=connectors/<name> command is passing
  • [ ] New Connector version released on Dockerhub by running the /publish command described here
  • [ ] After the connector is published, connector added to connector index as described here
  • [ ] Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • [ ] Grant edit access to maintainers (instructions)
  • [ ] Secrets in the connector's spec are annotated with airbyte_secret
  • [ ] Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • [ ] Code reviews completed
  • [ ] Documentation updated
    • [ ] Connector's README.md
    • [ ] Connector's bootstrap.md. See description and examples
    • [ ] Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • [ ] PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • [ ] Create a non-forked branch based on this PR and test the below items on it
  • [ ] Build is successful
  • [ ] If new credentials are required for use in CI, add them to GSM. Instructions.
  • [ ] /test connector=connectors/<name> command is passing
  • [ ] New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • [ ] Issue acceptance criteria met
  • [ ] PR name follows PR naming conventions
  • [ ] If adding a new generator, add it to the list of scaffold modules being tested
  • [ ] The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • [ ] Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

yurii-bidiuk avatar Sep 12 '22 09:09 yurii-bidiuk

NOTE :warning: Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-aws-datalake

github-actions[bot] avatar Sep 12 '22 09:09 github-actions[bot]

NOTE :warning: Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-aws-datalake

github-actions[bot] avatar Sep 12 '22 13:09 github-actions[bot]

/test connector=connectors/destination-aws-datalake

:clock2: connectors/destination-aws-datalake https://github.com/airbytehq/airbyte/actions/runs/3037661317 :x: connectors/destination-aws-datalake https://github.com/airbytehq/airbyte/actions/runs/3037661317 :bug: https://gradle.com/s/tmtipbq6ccaqg

Build Failed

Test summary info:

Could not find result summary

yurii-bidiuk avatar Sep 12 '22 13:09 yurii-bidiuk

/test connector=connectors/destination-aws-datalake

:clock2: connectors/destination-aws-datalake https://github.com/airbytehq/airbyte/actions/runs/3044270783 :x: connectors/destination-aws-datalake https://github.com/airbytehq/airbyte/actions/runs/3044270783 :bug: https://gradle.com/s/d76nk2r7e4cmm

Build Failed

Test summary info:

Could not find result summary

yurii-bidiuk avatar Sep 13 '22 10:09 yurii-bidiuk

NOTE :warning: Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-aws-datalake

github-actions[bot] avatar Sep 13 '22 10:09 github-actions[bot]

/test connector=connectors/destination-aws-datalake

:clock2: connectors/destination-aws-datalake https://github.com/airbytehq/airbyte/actions/runs/3044525874 :x: connectors/destination-aws-datalake https://github.com/airbytehq/airbyte/actions/runs/3044525874 :bug: https://gradle.com/s/puerzpm5afbha

Build Failed

Test summary info:

Could not find result summary

yurii-bidiuk avatar Sep 13 '22 11:09 yurii-bidiuk

testSync and testSyncWithLargeRecordBatch from AwsDatalakeDestinationAcceptanceTest are broken on the master I created follow-up ticket for that.

yurii-bidiuk avatar Sep 13 '22 11:09 yurii-bidiuk

@marcosmarxm I noticed that you changed secrets for destination-aws-datalake by adding "serialization_library" field. With this field, some of the tests are failing (see the job) with message: TypeError: __init__() got an unexpected keyword argument 'serialization_library'. After rollback to the previous version of a secret, it started working again. Could you please clarify if we still need this config?

yurii-bidiuk avatar Sep 13 '22 12:09 yurii-bidiuk