airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

Cron String: Clean up.

Open davinchia opened this issue 3 years ago • 3 comments

Tell us about the problem you're trying to solve

Last part of #2170 . Follow up to #11431 .

Clean up work:

  • Write a db migration to migrate any rows in the connection table with the old manual column set and the old schedule format that do not have the new scheduleType column set to the new schema. After that, drop the old manual column. This migrates all the previous connections schedules to the new format.
  • Remove all backward compatible code in the persistance layer, the server and the temporal workflow.

Describe the solution you’d like

A clear and concise description of what you want to see happen, or the change you would like to see

Describe the alternative you’ve considered or used

A clear and concise description of any alternative solutions or features you've considered or are using today.

Additional context

Add any other context or screenshots about the feature request here.

Are you willing to submit a PR?

Remove this with your answer :-)

davinchia avatar Mar 25 '22 13:03 davinchia

Note: in the scope of this task, let's ensure that we have validation where it's warranted around sending sane scheduling info (e.g., schedule type matches schedule data should be validated in the api and in the persistence layer).

mfsiega-airbyte avatar Aug 30 '22 18:08 mfsiega-airbyte

Note: revisit e2e test cases before closing this out.

mfsiega-airbyte avatar Sep 13 '22 15:09 mfsiega-airbyte

Note: consider if there's any code duplication to be cleaned up (e.g., https://github.com/airbytehq/airbyte/pull/16690).

mfsiega-airbyte avatar Sep 14 '22 08:09 mfsiega-airbyte