airbyte
airbyte copied to clipboard
Cron String: Clean up.
Tell us about the problem you're trying to solve
Last part of #2170 . Follow up to #11431 .
Clean up work:
- Write a db migration to migrate any rows in the
connectiontable with the oldmanualcolumn set and the oldscheduleformat that do not have the newscheduleTypecolumn set to the new schema. After that, drop the oldmanualcolumn. This migrates all the previous connections schedules to the new format. - Remove all backward compatible code in the persistance layer, the server and the temporal workflow.
Describe the solution you’d like
A clear and concise description of what you want to see happen, or the change you would like to see
Describe the alternative you’ve considered or used
A clear and concise description of any alternative solutions or features you've considered or are using today.
Additional context
Add any other context or screenshots about the feature request here.
Are you willing to submit a PR?
Remove this with your answer :-)
Note: in the scope of this task, let's ensure that we have validation where it's warranted around sending sane scheduling info (e.g., schedule type matches schedule data should be validated in the api and in the persistence layer).
Note: revisit e2e test cases before closing this out.
Note: consider if there's any code duplication to be cleaned up (e.g., https://github.com/airbytehq/airbyte/pull/16690).