airbyte-platform icon indicating copy to clipboard operation
airbyte-platform copied to clipboard

add resource requests and limits to airbyte minio container

Open machariamuguku opened this issue 1 year ago • 5 comments

What

  • Fixes https://github.com/airbytehq/airbyte/issues/30509
  • Adds resource requests and limits to the airbyte minio container

How

  • Add optional resource requests and limits configs to main helm chart

Recommended reading order

  1. minio.yaml
  2. values.yaml
  3. README.md

Can this PR be safely reverted / rolled back?

  • [x] YES 💚
  • [ ] NO ❌

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

machariamuguku avatar Sep 17 '23 23:09 machariamuguku

Note:

  • The ref link (ref: http://kubernetes.io/docs/user-guide/compute-resources/) is broken
  • Likely moved to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
  • The same is referred to in many other places within the charts and thus can easily be found in case of global replace

machariamuguku avatar Sep 17 '23 23:09 machariamuguku

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.7% 1.7% Duplication

sonarqubecloud[bot] avatar Dec 05 '23 10:12 sonarqubecloud[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 06 '24 09:03 CLAassistant

@perangel you seem to have started working on this. Any update?

machariamuguku avatar Apr 29 '24 18:04 machariamuguku