airbyte-platform icon indicating copy to clipboard operation
airbyte-platform copied to clipboard

Fix extraContainers in Cron helm chart

Open nightmareartist opened this issue 1 year ago • 2 comments

What

If current chart is used with extraContainers enabled the deployment will fail with the following error message:

Error: YAML parse error on cron/templates/deployment.yaml: error converting YAML to JSON: yaml: line 94: did not find expected key

This is not a problem when global extraContainers is used, but if, for example, we want Cron specific sidecar containers the setup will fail.

How

Added proper indentation to line 154.

Can this PR be safely reverted / rolled back?

If unsure, leave it blank.

  • [X ] YES 💚
  • [ ] NO ❌

🚨 User Impact 🚨

None.

nightmareartist avatar Sep 06 '23 09:09 nightmareartist

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar May 07 '24 21:05 CLAassistant

This is still an active issue. Could we please get this merged in and fixed? The proposed change from nindent 6 to nindent 8 is valid.

Thanks!

PurseChicken avatar Jul 22 '24 18:07 PurseChicken