airbyte-platform icon indicating copy to clipboard operation
airbyte-platform copied to clipboard

support existing secrets for aws creds

Open sh4sh opened this issue 1 year ago • 3 comments

What

Partially addresses https://github.com/airbytehq/airbyte/issues/22529 There are helm values to override AWS_SECRET_ACCESS_KEY and AWS_ACCESS_KEY_ID with existing secrets, but at the moment they don't seem to work. I added some logic to support these values.

Can this PR be safely reverted / rolled back?

If you know that your PR is backwards-compatible and can be simply reverted or rolled back, check the YES box.

Otherwise if your PR has a breaking change, like a database migration for example, check the NO box.

If unsure, leave it blank.

  • [x] YES 💚
  • [ ] NO ❌

sh4sh avatar May 05 '23 18:05 sh4sh

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 27.67% :green_apple:

github-actions[bot] avatar May 05 '23 18:05 github-actions[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar May 07 '24 21:05 CLAassistant

Your branch is not currently up-to-date with main. Please update your branch before attempting to snapshot your PR.

github-actions[bot] avatar May 07 '24 21:05 github-actions[bot]