fix: "write /dev/stdout: broken pipe" error during execution

[nicob3y]

I have encountered this error many times during my tests.

Summary by CodeRabbit

• Refactor
  • Improved the application's background process management for enhanced reliability and robustness in resource handling.

[coderabbitai[bot]]

📝 Walkthrough

Walkthrough

The changes refactor the cleanup logic within the _stream_from_subprocess context manager in the Airbyte executor. The updated implementation uses a try block to handle process termination and exit code checking, followed by a finally block to ensure that the stdout stream is always closed. The existing comments regarding broken pipe errors remain unchanged. There were no modifications to exported or public entities.

Changes

File	Summary
airbyte/_executors/base.py	Refactored cleanup logic in _stream_from_subprocess to wrap termination and exit code checking in a try block, with a finally block closing stdout.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant StreamManager as _stream_from_subprocess
    participant Subprocess

    Caller ->> StreamManager: Initiate subprocess streaming
    StreamManager ->> Subprocess: Start subprocess and stream output
    alt Process termination (try block)
        StreamManager ->> Subprocess: Attempt termination & exit code check
    end
    StreamManager ->> Subprocess: Finally close stdout
    StreamManager -->> Caller: Return stream data or error signal

Would you like to adjust or add more details to the sequence diagram, wdyt?

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1c1cd2a07a4dbb544125adf6325a6aae5b5bd24e and 1ab5102ac57a5442fbe8f99d2bf1ef9dcda15192.

📒 Files selected for processing (1)

• airbyte/_executors/base.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• airbyte/_executors/base.py

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Pytest (No Creds)
• GitHub Check: Pytest (Fast)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[aaronsteers]

/test-pr

PR test job started... Check job output.

❌ Tests failed.

[aaronsteers]

/test-pr

PR test job started... Check job output.

❌ Tests failed.

[aaronsteers]

@nicob3y - Thanks very much for contributing! :pray: I'm excited to accept this PR. We had some blocking CI issues that were preventing this from being tested. Running the full test suite now and will merge if tests can pass. :eyes:

[aaronsteers]

/test-pr

PR test job started... Check job output.

❌ Tests failed.

[aaronsteers]

/test-pr

PR test job started... Check job output.

❌ Tests failed.

[aaronsteers]

/test-pr

PR test job started... Check job output.

✅ Tests passed.