PyAirbyte icon indicating copy to clipboard operation
PyAirbyte copied to clipboard

Feat: Support pandas in BigQuery cache

Open jscheel opened this issue 11 months ago • 5 comments

Uses the pandas_gpb library to support fetching BigQuery tables to pandas DataFrames.

Summary by CodeRabbit

  • New Features

    • Added support for reading BigQuery data using Pandas.
    • Introduced a new method for converting SQL tables to Pandas DataFrames.
  • Dependencies

    • Added pandas-gbq package to project dependencies.
  • Improvements

    • Enhanced data handling methods in cache classes.
    • Streamlined dataset conversion in integration tests.
  • Bug Fixes

    • Removed cache type-specific conditional checks in test functions.

jscheel avatar Jan 29 '25 22:01 jscheel

📝 Walkthrough

Walkthrough

This pull request introduces modifications to the caching and data reading mechanisms in the Airbyte project. The changes primarily focus on enhancing the data retrieval process for different cache types, with a specific emphasis on BigQuery integration. The modifications include adding a new private method for reading SQL tables into Pandas DataFrames, updating import statements, and adding a new dependency to support BigQuery data handling.

Changes

File Change Summary
airbyte/caches/base.py - Added _read_to_pandas_dataframe method
- Updated paired_destination_config method signature
airbyte/caches/bigquery.py - Replaced get_arrow_dataset with _read_to_pandas_dataframe
- Updated import statements
pyproject.toml - Added pandas-gbq dependency (version >=0.26.1)
tests/integration_tests/cloud/test_cloud_sql_reads.py
tests/integration_tests/test_all_cache_types.py
- Simplified dataset conversion tests
- Removed conditional checks in test functions

Possibly related PRs

  • airbytehq/PyAirbyte#281: Changes in data reading methods for Pandas DataFrames.
  • airbytehq/PyAirbyte#407: SQL execution method additions related to _read_to_pandas_dataframe.
  • airbytehq/PyAirbyte#298: Introduction of _read_to_pandas_dataframe in the BigQueryCache class.

Suggested Labels

enable-ai-review

Suggested Reviewers

  • aaronsteers

Hey there! 👋 I noticed some interesting changes in the caching and data retrieval mechanisms. The new _read_to_pandas_dataframe method looks like it'll streamline how we handle data across different cache types. Would you be interested in discussing the rationale behind moving from get_arrow_dataset to this new approach? Wdyt? 🤔

The addition of pandas-gbq seems to be a key enabler for the BigQuery integration. Are there any specific performance or compatibility improvements you're aiming for with this change? Always curious to hear the backstory! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4826e225c88a7979c6dc957be8d98f1e8dbca17e and 18412c74547d670757a34aedfed44aaca701aabe.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • airbyte/caches/base.py (5 hunks)
  • pyproject.toml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • pyproject.toml
  • airbyte/caches/base.py
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Pytest (No Creds)
  • GitHub Check: Pytest (Fast)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jan 29 '25 22:01 coderabbitai[bot]

/fix-pr

Auto-Fix Job Info

This job attempts to auto-fix any linting or formating issues. If any fixes are made, those changes will be automatically committed and pushed back to the PR. (This job requires that the PR author has "Allow edits from maintainers" enabled.)

PR auto-fix job started... Check job output.

✅ Changes applied successfully.

aaronsteers avatar Feb 01 '25 02:02 aaronsteers

/test-pr

PR test job started... Check job output.

❌ Tests failed.

aaronsteers avatar Feb 01 '25 02:02 aaronsteers

/poetry-lock

poetry lock job started... Check job output.

poetry lock applied successfully.

aaronsteers avatar Mar 28 '25 21:03 aaronsteers

/fix-pr

Auto-Fix Job Info

This job attempts to auto-fix any linting or formating issues. If any fixes are made, those changes will be automatically committed and pushed back to the PR. (This job requires that the PR author has "Allow edits from maintainers" enabled.)

PR auto-fix job started... Check job output.

🟦 Job completed successfully (no changes).

aaronsteers avatar Mar 28 '25 22:03 aaronsteers