visx
visx copied to clipboard
airbnb
add textPath prop to Text component
This was implemented as a solution for https://github.com/airbnb/visx/issues/759 It is my first PR to a big open-source project. I'd appreciate your feeback.
:boom: Breaking Changes
- none
:rocket: Enhancements
- Adds an optional textPath props that can be used as a path for the text to follow along
Pull Request Test Coverage Report for Build 385720793
- 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
- 28 unchanged lines in 3 files lost coverage.
- Overall coverage decreased (-0.9%) to 59.923%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| packages/visx-xychart/src/components/XYChart.tsx | 1 | 94.74% |
| packages/visx-annotation/src/components/EditableAnnotation.tsx | 6 | 38.46% |
| packages/visx-brush/src/Brush.tsx | 21 | 2.42% |
| <!-- | Total: | 28 |
| Totals | |
|---|---|
| Change from base Build 348549012: | -0.9% |
| Covered Lines: | 1636 |
| Relevant Lines: | 2573 |
💛 - Coveralls
@grsoares21 I'm very sorry, Text has been refactored by hook(#946 ) that means you should rewrite this feature...... I‘m sincerely sorry about it........
@grsoares21 I'm very sorry,
Texthas been refactored byhook(#946 ) that means you should rewrite this feature...... I‘m sincerely sorry about it........
Hello @susiwen8 . No problems :D. I'm glad to hear it's on hooks now. I'll try to reimplement this next weekend then.
Sorry for the delayed review, will try and review asap once I see any new commits to avoid any future conflicts 👍
Came here for this very thing. Sad to see it has stalled. Are you planning to pick it up again @grsoares21 ?
If someone else wants to pick this up I'm happy to review! it shouldn't be too complicated, tho as noted @visx/text was refactored to use hooks so the approach will need to be tweaked slightly for that.