airbnb
fix: don't include all of lodash
:boom: Breaking Changes
- None
:rocket: Enhancements
- Visx packages now only depend on specific lodash function packages, rather than all of lodash. This affects
visx-responsive,visx-text, andvisx-xychart.
:memo: Documentation
- None
:bug: Bug Fix
- None
:house: Internal
- None
@williaster can we get this merged please? Let me know if there is anything else outstanding.
@RobinClowers have you considered replacing lodash entirely with https://es-toolkit.slash.page/?
It should be faster and smaller while being more or less a drop in replacement for lodash functions.
@VIKTORVAV99 I hadn't heard of es toolkit, looks like an awesome project!
Since many of these projects only depend on one or two functions, I'm not sure the savings would be significant (compared to all of lodash). Also, there might be subtle differences in the behavior between the libraries. That said, it sounds like a good improvement, but I'm not personally motivated to make the change. Especially since this low risk PR hasn't been merged, I worry that it would be wasted effort.
Oh, one other concern, I didn't know what the browser support policy is for visx, it might not be safe to depend on modern is for this project. For my project it would be, but again I haven't looked closely at the browser support guarantees visx provides.