paris icon indicating copy to clipboard operation
paris copied to clipboard

TextViewProxy should support minHeight

Open onwardzhang opened this issue 5 years ago • 1 comments

Right now, TextViewProxy doesn't support minHeight. https://developer.android.com/reference/android/widget/TextView#setMinHeight(int) TextView has this special property. If we don't support this, it may use the View.setMinimumHeight(int) which is supported in our ViewProxy

The value given here is different than View.setMinimumHeight(int). Between minHeight and the value set in View.setMinimumHeight(int), the greater one is used to decide the final height.

We already support minWidth for TextView, we probably should also support minHeight. I can add this.

onwardzhang avatar Sep 13 '19 21:09 onwardzhang

@onwardzhang sounds like a good addition. I'd be happy to review a pull request that adds this attribute.

ngsilverman avatar Dec 13 '19 19:12 ngsilverman