lunar icon indicating copy to clipboard operation
lunar copied to clipboard

fix(Autocomplete): isItemSelected default check is not accessible

Open ktmud opened this issue 3 years ago • 1 comments

to: @williaster @alecklandgraf

Description

The doc states isItemSelected of Autocomplete will compare values by default, but without setting this prop, it's actually always returning false. Since changing the default behavior would be a breaking change, I'm adding null to allow prop values in typing so that users can have access to the actual default behavior.

Motivation and Context

See description.

Testing

Make sure <Autocomplete isItemSelected={null} > doesn't throw type check errors.

Screenshots

Checklist

  • My code follows the style guide of this project.
  • I have updated or added documentation accordingly.
  • I have read the CONTRIBUTING document.

ktmud avatar Oct 23 '20 21:10 ktmud

Size Changes

Package Diff ESM Prev ESM CJS Prev CJS
core +0.0% 567.36 KB 567.33 KB 709.52 KB 709.46 KB

Compared to master. File sizes are unminified and ungzipped.

View raw build stats

Previous (master)

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 580945,
    "lib": 726482
  },
  "forms": {
    "esm": 37350,
    "lib": 49298
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

Current

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 580981,
    "lib": 726548
  },
  "forms": {
    "esm": 37350,
    "lib": 49298
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

airbnb-bot avatar Oct 23 '20 21:10 airbnb-bot