lottie-ios
lottie-ios copied to clipboard
Fix parsing issue, add support for DotLottieConfiguration in SwiftUI LottieView
This PR fixes two issues:
- Fixes #2269
- Fixes #2228
For #2269, we were failing to parse the animation. It's missing some fields that iOS requires, but that web doesn't require. We can relax the parsing a bit to allow this animation to parse successfully.
When testing the animation after fixing the parsing issue, I ran in to #2228. I bundled that animation and its image assets in a dotLottie file, but it was completely blank because the DotLottieConfiguration.imageProvider
was being ignored.
Before #2269 | Before fixing #2228 | After |
---|---|---|
1 build increased size
Name | Version | Download | Change | Install | Change |
---|---|---|---|---|---|
SizeTest com.airbnb.lottie.sizetest.iOS |
1.0 (1) | 752.5 kB | ⬆️ 5.9 kB (0.79%) | 2.3 MB | ⬆️ 20.4 kB (0.93%) |
SizeTest 1.0 (1)
com.airbnb.lottie.sizetest.iOS
⚖️ Compare build ⏱️ Analyze build performance
Total install size change: ⬆️ 20.4 kB (0.93%) Total download size change: ⬆️ 5.9 kB (0.79%)
Largest size changes
Item | Install Size Change |
---|---|
📝 Lottie.Dictionary.value(for,file,line) | ⬆️ 8.2 kB |
🗑 Lottie.Dictionary.value(for) | ⬇️ -7.2 kB |
Strings.Swift File Paths | ⬆️ 4.4 kB |
📝 Lottie.LottieView.applyCurrentAnimationConfiguration(to) | ⬆️ 1.9 kB |
DYLD.Fixups | ⬆️ 1.3 kB |
:flying_saucer: Powered by Emerge Tools