knowledge-repo icon indicating copy to clipboard operation
knowledge-repo copied to clipboard

Feedback

Open ethen8181 opened this issue 7 years ago • 2 comments

Hi team,

Thanks for taking the time to create this! I've been trying to adapt some analysis to Knowledge Repo (KR) and found some missing features/issues to it:

  1. Is it possible to change the font size of the text by clicking at some buttons inside a post?
  2. The aesthetic for the code chunk and its output looks pretty similar, can this be modified? (In juyter notebook code chunk has a grey background, whereas the output has a white background, but for KR both are in grey)
  3. Is it possible to have a table of content floating on the left of a post?

I can submit a separate request if that makes life easier.

Auto-reviewers: @NiharikaRay @matthewwardrop @earthmancash @danfrankj

ethen8181 avatar Nov 07 '17 17:11 ethen8181

@ethen8181 Number 3 (table of contents) has actually been implemented since the last release. If you install from source (in a requirements.txt, -e git://github.com/airbnb/knowledge-repo.git#egg=knowledge-repo), you'll get all the updated templates, auth, etc that have been committed to master since 0.7.6.

I agree about the code vs. output aesthetic. Can you make a PR to adjust that? Should likely be handled here.

alecraso avatar Jan 04 '18 17:01 alecraso

@aaronbiller , sorry for the late response. I have zero knowledge about html/css..., do you mean changing it to:

.renderedMarkdown .code-output {
  background: #ffffff;  /* change it to all white */
  padding: 15px;
  overflow: auto;
  border-left: solid #6BD2CA 10px;
}

I am having trouble testing this, as I got some errors when executing the latest version (0.7.6) of the knowledge repo. Errors are shown below:

# borrowing command from the README to create an example post
$ knowledge_repo --repo ./example_repo create ipynb example_post.ipynb

Traceback (most recent call last):
  File "/Users/ethen/anaconda/bin/knowledge_repo", line 4, in <module>
    __import__('pkg_resources').run_script('knowledge-repo==0.7.6', 'knowledge_repo')
  File "/Users/ethen/anaconda/lib/python3.5/site-packages/pkg_resources/__init__.py", line 750, in run_script
    self.require(requires)[0].run_script(script_name, ns)
  File "/Users/ethen/anaconda/lib/python3.5/site-packages/pkg_resources/__init__.py", line 1518, in run_script
    .format(**locals()),
pkg_resources.ResolutionError: Script 'scripts/knowledge_repo' not found in metadata at '/Users/ethen/anaconda/lib/python3.5/site-packages/knowledge_repo-0.7.6.dist-info'

Not sure if you've came across the same issue.

ethen8181 avatar Jan 20 '18 04:01 ethen8181