kafka-statsd-metrics2 icon indicating copy to clipboard operation
kafka-statsd-metrics2 copied to clipboard

Take statsd host and port from environment if missing in the config.

Open porridge opened this issue 6 years ago • 3 comments

Fixes: #28

porridge avatar Jun 12 '18 12:06 porridge

I manually tested that:

  • omitting the settings from both environment and config properties falls back to localhost:8125
  • omitting settings from config properties but providing them in the environment picks up the latter

Please let me know whether I should bump version (and to what, since master seem to be 0.5.2 but there is some mysterious 0.5.3 at https://bintray.com/airbnb/jars/kafka-statsd-metrics2/0.5.3#files/com%2Fairbnb%2Fkafka-statsd-metrics2%2F0.5.3).

porridge avatar Jun 12 '18 12:06 porridge

friendly ping, anyone? @ziliangpeng ?

porridge avatar Jun 20 '18 07:06 porridge

friendly ping again, @ziliangpeng @alexism @parasitew

porridge avatar Aug 13 '18 11:08 porridge